-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[libc] wcstok implementation #145989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[libc] wcstok implementation #145989
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| //===-- Implementation of wcstok ------------------------------------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #include "src/wchar/wcstok.h" | ||
|
|
||
| #include "hdr/types/wchar_t.h" | ||
| #include "src/__support/common.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
|
|
||
| LLVM_LIBC_FUNCTION(wchar_t *, wcstok, | ||
| (wchar_t *__restrict str, const wchar_t *__restrict delim, | ||
| wchar_t **__restrict ptr)) { | ||
| if (str == nullptr) | ||
| str = *ptr; | ||
|
|
||
| bool foundTokenStart = false; | ||
uzairnawaz marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| wchar_t *out = nullptr; | ||
| wchar_t *str_ptr; | ||
| for (str_ptr = str; *str_ptr != L'\0'; str_ptr++) { | ||
uzairnawaz marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| bool inDelim = false; | ||
| for (const wchar_t *delim_ptr = delim; *delim_ptr != L'\0' && !inDelim; | ||
| delim_ptr++) | ||
| if (*str_ptr == *delim_ptr) | ||
| inDelim = true; | ||
uzairnawaz marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| if (!inDelim && !foundTokenStart) { | ||
| foundTokenStart = true; | ||
| out = str_ptr; | ||
| } else if (inDelim && foundTokenStart) { | ||
| *str_ptr = L'\0'; | ||
| *ptr = str_ptr + 1; | ||
| return out; | ||
| } | ||
| } | ||
|
|
||
| *ptr = str_ptr; | ||
| return out; | ||
| } | ||
|
|
||
| } // namespace LIBC_NAMESPACE_DECL | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| //===-- Implementation header for wcstok ----------------------------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_LIBC_SRC_WCHAR_WCSTOK_H | ||
| #define LLVM_LIBC_SRC_WCHAR_WCSTOK_H | ||
|
|
||
| #include "hdr/types/wchar_t.h" | ||
| #include "src/__support/macros/config.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
|
|
||
| wchar_t *wcstok(wchar_t *__restrict str, const wchar_t *__restrict delim, | ||
| wchar_t **__restrict ptr); | ||
|
|
||
| } // namespace LIBC_NAMESPACE_DECL | ||
|
|
||
| #endif // LLVM_LIBC_SRC_WCHAR_WCSTOK_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,145 @@ | ||
| //===-- Unittests for wcstok ----------------------------------------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #include "hdr/types/size_t.h" | ||
| #include "hdr/types/wchar_t.h" | ||
| #include "src/wchar/wcstok.h" | ||
| #include "test/UnitTest/Test.h" | ||
|
|
||
| TEST(LlvmLibcStrTokTest, NoTokenFound) { | ||
uzairnawaz marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| wchar_t empty[] = L""; | ||
| wchar_t *buf; | ||
| ASSERT_EQ(LIBC_NAMESPACE::wcstok(empty, L"", &buf), nullptr); | ||
| ASSERT_EQ(LIBC_NAMESPACE::wcstok(empty, L"_", &buf), nullptr); | ||
|
|
||
| wchar_t single[] = L"_"; | ||
| wchar_t *token = LIBC_NAMESPACE::wcstok(single, L"", &buf); | ||
| ASSERT_TRUE(token[0] == L'_'); | ||
| ASSERT_TRUE(token[1] == L'\0'); | ||
|
|
||
| wchar_t multiple[] = L"1,2"; | ||
| token = LIBC_NAMESPACE::wcstok(multiple, L":", &buf); | ||
| ASSERT_TRUE(multiple[0] == L'1'); | ||
| ASSERT_TRUE(multiple[1] == L','); | ||
| ASSERT_TRUE(multiple[2] == L'2'); | ||
| ASSERT_TRUE(multiple[3] == L'\0'); | ||
| } | ||
|
|
||
| TEST(LlvmLibcStrTokTest, DelimiterAsFirstCharacterShouldBeIgnored) { | ||
| wchar_t *buf; | ||
| wchar_t src[] = L".123"; | ||
| wchar_t *token = LIBC_NAMESPACE::wcstok(src, L".", &buf); | ||
| ASSERT_TRUE(token[0] == L'1'); | ||
| ASSERT_TRUE(token[1] == L'2'); | ||
| ASSERT_TRUE(token[2] == L'3'); | ||
| ASSERT_TRUE(token[3] == L'\0'); | ||
| } | ||
|
|
||
| TEST(LlvmLibcStrTokTest, DelimiterIsMiddleCharacter) { | ||
| wchar_t src[] = L"12,34"; | ||
| wchar_t *buf; | ||
| wchar_t *token = LIBC_NAMESPACE::wcstok(src, L",", &buf); | ||
| ASSERT_TRUE(token[0] == L'1'); | ||
| ASSERT_TRUE(token[1] == L'2'); | ||
| ASSERT_TRUE(token[2] == L'\0'); | ||
| } | ||
|
|
||
| TEST(LlvmLibcStrTokTest, DelimiterAsLastCharacterShouldBeIgnored) { | ||
| wchar_t src[] = L"1234:"; | ||
| wchar_t *buf; | ||
| wchar_t *token = LIBC_NAMESPACE::wcstok(src, L":", &buf); | ||
| ASSERT_TRUE(token[0] == L'1'); | ||
| ASSERT_TRUE(token[1] == L'2'); | ||
| ASSERT_TRUE(token[2] == L'3'); | ||
| ASSERT_TRUE(token[3] == L'4'); | ||
| ASSERT_TRUE(token[4] == L'\0'); | ||
| } | ||
|
|
||
| TEST(LlvmLibcStrTokTest, MultipleDelimiters) { | ||
| wchar_t src[] = L"12,.34"; | ||
| wchar_t *buf; | ||
| wchar_t *token; | ||
|
|
||
| token = LIBC_NAMESPACE::wcstok(src, L".", &buf); | ||
| ASSERT_TRUE(token[0] == L'1'); | ||
| ASSERT_TRUE(token[1] == L'2'); | ||
| ASSERT_TRUE(token[2] == L','); | ||
| ASSERT_TRUE(token[3] == L'\0'); | ||
|
|
||
| token = LIBC_NAMESPACE::wcstok(src, L".,", &buf); | ||
| ASSERT_TRUE(token[0] == L'1'); | ||
| ASSERT_TRUE(token[1] == L'2'); | ||
| ASSERT_TRUE(token[2] == L'\0'); | ||
|
|
||
| token = LIBC_NAMESPACE::wcstok(src, L",.", &buf); | ||
| ASSERT_TRUE(token[0] == L'1'); | ||
| ASSERT_TRUE(token[1] == L'2'); | ||
| ASSERT_TRUE(token[2] == L'\0'); | ||
|
|
||
| token = LIBC_NAMESPACE::wcstok(src, L":,.", &buf); | ||
| ASSERT_TRUE(token[0] == L'1'); | ||
| ASSERT_TRUE(token[1] == L'2'); | ||
| ASSERT_TRUE(token[2] == L'\0'); | ||
| } | ||
|
|
||
| TEST(LlvmLibcStrTokTest, ShouldNotGoPastNullTerminator) { | ||
| wchar_t src[] = {L'1', L'2', L'\0', L',', L'3'}; | ||
| wchar_t *buf; | ||
| wchar_t *token = LIBC_NAMESPACE::wcstok(src, L",", &buf); | ||
| ASSERT_TRUE(token[0] == L'1'); | ||
| ASSERT_TRUE(token[1] == L'2'); | ||
| ASSERT_TRUE(token[2] == L'\0'); | ||
| } | ||
|
|
||
| TEST(LlvmLibcStrTokTest, SubsequentCallsShouldFindFollowingDelimiters) { | ||
| wchar_t src[] = L"12,34.56"; | ||
| wchar_t *buf; | ||
| wchar_t *token = LIBC_NAMESPACE::wcstok(src, L",.", &buf); | ||
| ASSERT_TRUE(token[0] == L'1'); | ||
| ASSERT_TRUE(token[1] == L'2'); | ||
| ASSERT_TRUE(token[2] == L'\0'); | ||
|
|
||
| token = LIBC_NAMESPACE::wcstok(nullptr, L",.", &buf); | ||
| ASSERT_TRUE(token[0] == L'3'); | ||
| ASSERT_TRUE(token[1] == L'4'); | ||
| ASSERT_TRUE(token[2] == L'\0'); | ||
|
|
||
| token = LIBC_NAMESPACE::wcstok(nullptr, L",.", &buf); | ||
| ASSERT_TRUE(token[0] == L'5'); | ||
| ASSERT_TRUE(token[1] == L'6'); | ||
| ASSERT_TRUE(token[2] == L'\0'); | ||
|
|
||
| token = LIBC_NAMESPACE::wcstok(nullptr, L"_:,_", &buf); | ||
| ASSERT_EQ(token, nullptr); | ||
| // Subsequent calls after hitting the end of the string should also return | ||
| // nullptr. | ||
| token = LIBC_NAMESPACE::wcstok(nullptr, L"_:,_", &buf); | ||
| ASSERT_EQ(token, nullptr); | ||
| } | ||
|
|
||
| TEST(LlvmLibcStrTokTest, DelimitersShouldNotBeIncludedInToken) { | ||
| wchar_t *buf; | ||
| wchar_t src[] = L"__ab__:_cd__:__ef__:__"; | ||
| wchar_t *token = LIBC_NAMESPACE::wcstok(src, L"_:", &buf); | ||
| ASSERT_TRUE(token[0] == L'a'); | ||
| ASSERT_TRUE(token[1] == L'b'); | ||
| ASSERT_TRUE(token[2] == L'\0'); | ||
|
|
||
| token = LIBC_NAMESPACE::wcstok(nullptr, L":_", &buf); | ||
| ASSERT_TRUE(token[0] == L'c'); | ||
| ASSERT_TRUE(token[1] == L'd'); | ||
| ASSERT_TRUE(token[2] == L'\0'); | ||
|
|
||
| token = LIBC_NAMESPACE::wcstok(nullptr, L"_:,", &buf); | ||
| ASSERT_TRUE(token[0] == L'e'); | ||
| ASSERT_TRUE(token[1] == L'f'); | ||
| ASSERT_TRUE(token[2] == L'\0'); | ||
|
|
||
| token = LIBC_NAMESPACE::wcstok(nullptr, L"_:,_", &buf); | ||
| ASSERT_EQ(token, nullptr); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.