[mlir] Use a new constructor of ArrayRef (NFC) #146009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArrayRef now has a new constructor that takes a parameter whose type has data() and size(). This patch migrates: ArrayRef<T>(X.data(), X.size() to: ArrayRef<T>(X)
Member
|
@llvm/pr-subscribers-mlir-llvm @llvm/pr-subscribers-mlir-core Author: Kazu Hirata (kazutakahirata) ChangesArrayRef now has a new constructor that takes a parameter whose type ArrayRef<T>(X.data(), X.size() to: ArrayRef<T>(X) Full diff: https://github.com/llvm/llvm-project/pull/146009.diff 2 Files Affected:
diff --git a/mlir/lib/AsmParser/AttributeParser.cpp b/mlir/lib/AsmParser/AttributeParser.cpp
index 2474e88373e04..dcb21e7d0831d 100644
--- a/mlir/lib/AsmParser/AttributeParser.cpp
+++ b/mlir/lib/AsmParser/AttributeParser.cpp
@@ -717,7 +717,7 @@ DenseElementsAttr TensorLiteralParser::getHexAttr(SMLoc loc, ShapedType type) {
if (parseElementAttrHexValues(p, *hexStorage, data))
return nullptr;
- ArrayRef<char> rawData(data.data(), data.size());
+ ArrayRef<char> rawData(data);
bool detectedSplat = false;
if (!DenseElementsAttr::isValidRawBuffer(type, rawData, detectedSplat)) {
p.emitError(loc) << "elements hex data size is invalid for provided type: "
diff --git a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
index 1253c2f83b07b..8dcffc66f7f7b 100644
--- a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
@@ -727,10 +727,8 @@ llvm::Constant *mlir::LLVM::detail::getLLVMConstant(
}
if (auto stringAttr = dyn_cast<StringAttr>(attr)) {
- return llvm::ConstantDataArray::get(
- moduleTranslation.getLLVMContext(),
- ArrayRef<char>{stringAttr.getValue().data(),
- stringAttr.getValue().size()});
+ return llvm::ConstantDataArray::get(moduleTranslation.getLLVMContext(),
+ ArrayRef<char>{stringAttr.getValue()});
}
// Handle arrays of structs that cannot be represented as DenseElementsAttr
|
Member
|
@llvm/pr-subscribers-mlir Author: Kazu Hirata (kazutakahirata) ChangesArrayRef now has a new constructor that takes a parameter whose type ArrayRef<T>(X.data(), X.size() to: ArrayRef<T>(X) Full diff: https://github.com/llvm/llvm-project/pull/146009.diff 2 Files Affected:
diff --git a/mlir/lib/AsmParser/AttributeParser.cpp b/mlir/lib/AsmParser/AttributeParser.cpp
index 2474e88373e04..dcb21e7d0831d 100644
--- a/mlir/lib/AsmParser/AttributeParser.cpp
+++ b/mlir/lib/AsmParser/AttributeParser.cpp
@@ -717,7 +717,7 @@ DenseElementsAttr TensorLiteralParser::getHexAttr(SMLoc loc, ShapedType type) {
if (parseElementAttrHexValues(p, *hexStorage, data))
return nullptr;
- ArrayRef<char> rawData(data.data(), data.size());
+ ArrayRef<char> rawData(data);
bool detectedSplat = false;
if (!DenseElementsAttr::isValidRawBuffer(type, rawData, detectedSplat)) {
p.emitError(loc) << "elements hex data size is invalid for provided type: "
diff --git a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
index 1253c2f83b07b..8dcffc66f7f7b 100644
--- a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
@@ -727,10 +727,8 @@ llvm::Constant *mlir::LLVM::detail::getLLVMConstant(
}
if (auto stringAttr = dyn_cast<StringAttr>(attr)) {
- return llvm::ConstantDataArray::get(
- moduleTranslation.getLLVMContext(),
- ArrayRef<char>{stringAttr.getValue().data(),
- stringAttr.getValue().size()});
+ return llvm::ConstantDataArray::get(moduleTranslation.getLLVMContext(),
+ ArrayRef<char>{stringAttr.getValue()});
}
// Handle arrays of structs that cannot be represented as DenseElementsAttr
|
arsenm
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrayRef now has a new constructor that takes a parameter whose type
has data() and size(). This patch migrates:
ArrayRef(X.data(), X.size()
to:
ArrayRef(X)