[Clang][NFC] - Move attr-cpuspecific-cpus test over to Sema #146065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-clang Author: Pawan Nirpal (pawan-nirpal-031) ChangesThe attr-cpuspecific-cpus test does not have any LLVM IR checks relevant to Codegen, Moving the test over to clang/test/Sema. Full diff: https://github.com/llvm/llvm-project/pull/146065.diff 1 Files Affected:
diff --git a/clang/test/CodeGen/attr-cpuspecific-cpus.c b/clang/test/Sema/attr-cpuspecific-cpus.c
similarity index 97%
rename from clang/test/CodeGen/attr-cpuspecific-cpus.c
rename to clang/test/Sema/attr-cpuspecific-cpus.c
index 1dd095ec9e191..6f26b2012c4f4 100644
--- a/clang/test/CodeGen/attr-cpuspecific-cpus.c
+++ b/clang/test/Sema/attr-cpuspecific-cpus.c
@@ -1,5 +1,5 @@
-// RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -emit-llvm -o - %s
-// RUN: %clang_cc1 -verify -triple x86_64-windows-pc -fms-compatibility -emit-llvm -o - %s
+// RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -o - %s
+// RUN: %clang_cc1 -verify -triple x86_64-windows-pc -fms-compatibility -o - %s
// expected-no-diagnostics
|
Contributor
Author
|
@AaronBallman can you please review. |
Co-authored-by: Aaron Ballman <[email protected]>
AaronBallman
approved these changes
Jun 27, 2025
Collaborator
AaronBallman
left a comment
AaronBallman
left a comment
There was a problem hiding this comment.
LGTM assuming precommit CI comes back green, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attr-cpuspecific-cpus test does not have any LLVM IR checks relevant to Codegen, Moving the test over to clang/test/Sema.