Skip to content

Make sure all matrix options are run in libc premerge testing #146162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 7, 2025
Merged

Make sure all matrix options are run in libc premerge testing #146162

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
38cf8c9
Make sure all matrix options are run in the libc premerge testing
amykhuang Jun 27, 2025
f5a6e45
Try to only build all of debug/release/minsizerel on linux fullbuilds
amykhuang Jun 30, 2025
3191cb9
Trying to figure out how the matrix works
amykhuang Jun 30, 2025
917a60d
Fix again
amykhuang Jun 30, 2025
d3a320e
Fix cmake var and remove extra line passing a MinSizeRel config
amykhuang Jul 2, 2025
5887557
add back release mode
amykhuang Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/libc-fullbuild-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
fail-fast: false
matrix:
build_type: [Debug, Release, MinSizeRel]
os: [ubuntu-24.04, ubuntu-24.04-arm]
include:
- os: ubuntu-24.04
ccache-variant: sccache
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/libc-overlay-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
fail-fast: false
matrix:
build_type: [Debug, Release, MinSizeRel]
os: [ubuntu-24.04, ubuntu-24.04-arm, windows-2022, windows-2025, macos-14]
Copy link
Contributor

@vonosmas vonosmas Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity - why is the list of os added here, but not to the matrix in .github/workflows/libc-fullbuild-tests.yml ?

Copy link
Contributor

@SchrodingerZhu SchrodingerZhu Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os/compiler combinations are not trivial here

include:
# TODO: add linux gcc when it is fixed
- os: ubuntu-24.04
Expand Down
Loading