Skip to content

[llvm] Compare std::optional<T> to values directly (NFC) #146222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025
Merged

[llvm] Compare std::optional<T> to values directly (NFC) #146222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/TargetParser/AArch64TargetParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ std::optional<AArch64::ArchInfo> AArch64::ArchInfo::findBySubArch(StringRef SubA

std::optional<AArch64::FMVInfo> lookupFMVByID(AArch64::ArchExtKind ExtID) {
for (const AArch64::FMVInfo &Info : AArch64::getFMVInfo())
if (Info.ID && *Info.ID == ExtID)
if (Info.ID == ExtID)
return Info;
return {};
}
Expand Down
2 changes: 1 addition & 1 deletion llvm/unittests/Support/RISCVAttributeParserTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ static bool testAttribute(unsigned Tag, unsigned Value, unsigned ExpectedTag,
cantFail(Parser.parse(Bytes, llvm::endianness::little));

std::optional<unsigned> Attr = Parser.getAttributeValue("", ExpectedTag);
return Attr && *Attr == ExpectedValue;
return Attr == ExpectedValue;
}

static bool testTagString(unsigned Tag, const char *name) {
Expand Down
Loading