Skip to content

[libomptarget] Add a test for OMP_TARGET_OFFLOAD=disabled #146385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

[libomptarget] Add a test for OMP_TARGET_OFFLOAD=disabled #146385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions offload/test/offloading/disable_default_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// RUN: %libomptarget-compile-generic
// RUN: env OMP_TARGET_OFFLOAD=disabled %libomptarget-run-generic 2>&1 |
Copy link
Member

@Meinersbur Meinersbur Jul 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is nobody testing this? Fails unconditionally with

# shell parser error on RUN: at line 2: env OMP_TARGET_OFFLOAD=disabled /home/meinersbur/src/llvm/work/release/runtimes/runtimes-bins/offload/test/x86_64-unknown-linux-gnu-LTO/offloading/Output/disable_default_device.c.tmp 2>&1 |

FileCheck %s is missing at the end of the line

Copy link
Contributor

@jhuber6 jhuber6 Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, didn't catch that. The OpenMP testing situation is a travesty and has been for several years.

Copy link
Contributor Author

@ye-luo ye-luo Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow clang-format added a new line and break the added test.

Copy link
Contributor Author

@ye-luo ye-luo Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9f6784c

// %fcheck-generic

#include <omp.h>
#include <stdio.h>

// Sanity checks to make sure that this works and is thread safe.
int main() {
// CHECK: number of devices 0
printf("number of devices %d\n", omp_get_num_devices());
// CHECK:initial device 0
printf("initial device %d\n", omp_get_initial_device());
// CHECK:default device 0
printf("default device %d\n", omp_get_default_device());
// CHECK: PASS
if (omp_get_initial_device() == omp_get_default_device()) {
printf("PASS\n");
return 0;
}
return 1;
}
Loading