Skip to content

[libc] Wchar Stringconverter #146388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 14, 2025
Merged

[libc] Wchar Stringconverter #146388

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
c1e1650
added tests
uzairnawaz Jun 30, 2025
de9385e
Merge branch 'main' into wchar-stringconverter
uzairnawaz Jun 30, 2025
f18221f
fixed test
uzairnawaz Jun 30, 2025
41e7e31
fixed dependencies; added comments
uzairnawaz Jun 30, 2025
e6453a2
StringConverter class complete!
uzairnawaz Jul 2, 2025
86fb76f
Updated internal member name (bytes_pushed isn't accurate)
uzairnawaz Jul 7, 2025
5e4b5e2
used proxy headers; improved tests
uzairnawaz Jul 8, 2025
19b9397
incremented src_idx on first pop rather than last
uzairnawaz Jul 9, 2025
8e969d9
formatting
uzairnawaz Jul 9, 2025
a5e8646
removed redundant bool
uzairnawaz Jul 9, 2025
7ef9579
exclude windows for wchar tests
uzairnawaz Jul 10, 2025
14fe00a
fixed stringconverter windows build
uzairnawaz Jul 14, 2025
d09f18e
formatting + explicit casts
uzairnawaz Jul 14, 2025
3eb3a5d
dont build wchar on windows (no utf16 support)
uzairnawaz Jul 14, 2025
13ef7db
replace cmake rule with macro
uzairnawaz Jul 14, 2025
8b4edac
add missing header
uzairnawaz Jul 14, 2025
7413151
remove stringconverter test from windows cmake
uzairnawaz Jul 14, 2025
bf5afbb
added dummy test for windows build
uzairnawaz Jul 14, 2025
b774085
cmake typo
uzairnawaz Jul 14, 2025
8a9a463
macro fix
uzairnawaz Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions libc/test/src/__support/wchar/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,16 @@ add_libc_test(
)


if(NOT(LIBC_TARGET_OS_IS_WINDOWS))
add_libc_test(
add_libc_test(
string_converter_test.cpp
SUITE
libc-support-tests
SRCS
string_converter_test.cpp
SUITE
libc-support-tests
SRCS
string_converter_test.cpp
DEPENDS
libc.src.__support.wchar.string_converter
libc.src.__support.wchar.mbstate
libc.src.__support.error_or
libc.hdr.errno_macros
libc.hdr.types.char32_t
)
endif()
DEPENDS
libc.src.__support.wchar.string_converter
libc.src.__support.wchar.mbstate
libc.src.__support.error_or
libc.hdr.errno_macros
libc.hdr.types.char32_t
)
15 changes: 10 additions & 5 deletions libc/test/src/__support/wchar/string_converter_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,24 @@
//
//===----------------------------------------------------------------------===//

// TODO: add support for 16-bit widechars to StringConverter to remove this
// macro
#include "src/__support/macros/properties/os.h"
#ifndef LIBC_TARGET_OS_IS_WINDOWS

#include "hdr/errno_macros.h"
#include "hdr/types/char32_t.h"
#include "hdr/types/char8_t.h"
#include "src/__support/error_or.h"
#include "src/__support/macros/properties/os.h"
#include "src/__support/wchar/mbstate.h"
#include "src/__support/wchar/string_converter.h"
#include "test/UnitTest/Test.h"

// TODO: add support for 16-bit widechars to StringConverter to remove this
// macro
#ifdef LIBC_TARGET_OS_IS_WINDOWS
TEST(LlvmLibcStringConverterTest, Windows) {
// pass on windows for now
}
#endif

#ifndef LIBC_TARGET_OS_IS_WINDOWS
TEST(LlvmLibcStringConverterTest, UTF8To32) {
// first 4 bytes are clown emoji (🤡)
// next 3 bytes are sigma symbol (∑)
Expand Down
Loading