-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[libc] Wchar Stringconverter #146388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+521
−1
Merged
[libc] Wchar Stringconverter #146388
Changes from 6 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c1e1650
added tests
uzairnawaz de9385e
Merge branch 'main' into wchar-stringconverter
uzairnawaz f18221f
fixed test
uzairnawaz 41e7e31
fixed dependencies; added comments
uzairnawaz e6453a2
StringConverter class complete!
uzairnawaz 86fb76f
Updated internal member name (bytes_pushed isn't accurate)
uzairnawaz 5e4b5e2
used proxy headers; improved tests
uzairnawaz 19b9397
incremented src_idx on first pop rather than last
uzairnawaz 8e969d9
formatting
uzairnawaz a5e8646
removed redundant bool
uzairnawaz 7ef9579
exclude windows for wchar tests
uzairnawaz 14fe00a
fixed stringconverter windows build
uzairnawaz d09f18e
formatting + explicit casts
uzairnawaz 3eb3a5d
dont build wchar on windows (no utf16 support)
uzairnawaz 13ef7db
replace cmake rule with macro
uzairnawaz 8b4edac
add missing header
uzairnawaz 7413151
remove stringconverter test from windows cmake
uzairnawaz bf5afbb
added dummy test for windows build
uzairnawaz b774085
cmake typo
uzairnawaz 8a9a463
macro fix
uzairnawaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| //===-- Definition of a class for mbstate_t and conversion -----*-- C++ -*-===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_LIBC_SRC___SUPPORT_STRING_CONVERTER_H | ||
| #define LLVM_LIBC_SRC___SUPPORT_STRING_CONVERTER_H | ||
|
|
||
| #include "hdr/types/char32_t.h" | ||
| #include "hdr/types/char8_t.h" | ||
| #include "hdr/types/size_t.h" | ||
| #include "src/__support/common.h" | ||
| #include "src/__support/error_or.h" | ||
| #include "src/__support/wchar/character_converter.h" | ||
| #include "src/__support/wchar/mbstate.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
| namespace internal { | ||
|
|
||
| template <typename T> class StringConverter { | ||
| private: | ||
| CharacterConverter cr; | ||
| const T *src; | ||
| size_t src_len; | ||
| size_t src_idx; | ||
| size_t num_pushed; | ||
uzairnawaz marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| size_t num_to_write; | ||
uzairnawaz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| int pushFullCharacter() { | ||
| for (num_pushed = 0; !cr.isFull() && src_idx + num_pushed < src_len; | ||
| ++num_pushed) { | ||
| int err = cr.push(src[src_idx + num_pushed]); | ||
| if (err != 0) | ||
| return err; | ||
| } | ||
|
|
||
| // if we aren't able to read a full character from the source string | ||
| if (src_idx + num_pushed == src_len && !cr.isFull()) { | ||
| src_idx += num_pushed; | ||
| return -1; | ||
| } | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| public: | ||
| StringConverter(const T *s, size_t srclen, size_t dstlen, mbstate *ps) | ||
| : cr(ps), src(s), src_len(srclen), src_idx(0), num_pushed(0), | ||
| num_to_write(dstlen) { | ||
| pushFullCharacter(); | ||
sribee8 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| StringConverter(const T *s, size_t dstlen, mbstate *ps) | ||
| : StringConverter(s, SIZE_MAX, dstlen, ps) {} | ||
uzairnawaz marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ErrorOr<char32_t> popUTF32() { | ||
uzairnawaz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if (cr.isEmpty()) { | ||
| int err = pushFullCharacter(); | ||
| if (err != 0) | ||
| return Error(err); | ||
|
|
||
| if (cr.sizeAsUTF32() > num_to_write) { | ||
| cr.clear(); | ||
| return Error(-1); | ||
| } | ||
| } | ||
|
|
||
| auto out = cr.pop_utf32(); | ||
| if (cr.isEmpty()) | ||
| src_idx += num_pushed; | ||
|
|
||
| if (out.has_value() && out.value() == L'\0') | ||
| src_len = src_idx; | ||
|
|
||
| num_to_write--; | ||
|
|
||
| return out; | ||
| } | ||
|
|
||
| ErrorOr<char8_t> popUTF8() { | ||
| if (cr.isEmpty()) { | ||
| int err = pushFullCharacter(); | ||
| if (err != 0) | ||
| return Error(err); | ||
|
|
||
| if (cr.sizeAsUTF8() > num_to_write) { | ||
| cr.clear(); | ||
| return Error(-1); | ||
| } | ||
| } | ||
|
|
||
| auto out = cr.pop_utf8(); | ||
| if (cr.isEmpty()) | ||
| src_idx += num_pushed; | ||
|
|
||
| if (out.has_value() && out.value() == '\0') | ||
| src_len = src_idx; | ||
|
|
||
| num_to_write--; | ||
|
|
||
| return out; | ||
| } | ||
|
|
||
| size_t getSourceIndex() { return src_idx; } | ||
| }; | ||
|
|
||
| } // namespace internal | ||
| } // namespace LIBC_NAMESPACE_DECL | ||
|
|
||
| #endif // LLVM_LIBC_SRC___SUPPORT_STRING_CONVERTER_H | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.