Skip to content

[lldb][Commands][NFC] image lookup: remove unused local variable #146554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Michael137 merged 3 commits into from
Jul 3, 2025
Merged

[lldb][Commands][NFC] image lookup: remove unused local variable #146554

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbc32ba
[lldb][Commands] image lookup: avoid double type lookup into current …
Michael137 Jul 1, 2025
44e27c4
fixup! remove current_module logic
Michael137 Jul 2, 2025
6cec208
fixup! remove test
Michael137 Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions lldb/source/Commands/CommandObjectTarget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4086,8 +4086,6 @@ class CommandObjectTargetModulesLookup : public CommandObjectParsed {
// Dump all sections for all modules images

if (command.GetArgumentCount() == 0) {
ModuleSP current_module;

// Where it is possible to look in the current symbol context first,
// try that. If this search was successful and --all was not passed,
// don't print anything else.
Expand All @@ -4110,8 +4108,7 @@ class CommandObjectTargetModulesLookup : public CommandObjectParsed {
}

for (ModuleSP module_sp : target_modules.ModulesNoLocking()) {
if (module_sp != current_module &&
LookupInModule(m_interpreter, module_sp.get(), result,
if (LookupInModule(m_interpreter, module_sp.get(), result,
syntax_error)) {
result.GetOutputStream().EOL();
num_successful_lookups++;
Expand Down
Loading