Skip to content

[flang][prescanner] fix invalid check #146613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025
Merged

[flang][prescanner] fix invalid check #146613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05836e0
initial commit
akuhlens Jul 1, 2025
f4beee5
add comment
akuhlens Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion flang/lib/Parser/token-sequence.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ void TokenSequence::clear() {

void TokenSequence::pop_back() {
CHECK(!start_.empty());
CHECK(nextStart_ > start_.back());
// If the last token is empty then `nextStart_ == start_.back()`.
CHECK(nextStart_ >= start_.back());
std::size_t bytes{nextStart_ - start_.back()};
nextStart_ = start_.back();
start_.pop_back();
Expand Down
5 changes: 5 additions & 0 deletions flang/test/Parser/issue-146362.1.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
! RUN: %flang_fc1 -fsyntax-only -cpp %s 2>&1
#define UNITY(k) 1_ ## k
PROGRAM REPRODUCER
WRITE(*,*) UNITY(4)
END PROGRAM REPRODUCER
Loading