-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[RISCV] Add optimization for memset inline #146673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
c72f8ba
1f7cbd9
c3b8eb6
5c74b2e
c819790
cc0f349
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1664,7 +1664,11 @@ RISCVTargetLowering::RISCVTargetLowering(const TargetMachine &TM, | |
| PredictableSelectIsExpensive = Subtarget.predictableSelectIsExpensive(); | ||
|
|
||
| MaxStoresPerMemsetOptSize = Subtarget.getMaxStoresPerMemset(/*OptSize=*/true); | ||
| MaxStoresPerMemset = Subtarget.getMaxStoresPerMemset(/*OptSize=*/false); | ||
| MaxStoresPerMemset = Subtarget.hasVInstructions() | ||
| ? (Subtarget.getRealMinVLen() / 8 * | ||
| Subtarget.getMaxLMULForFixedLengthVectors() / | ||
| (Subtarget.is64Bit() ? 8 : 4)) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this based on is64Bit?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If Op.size() exceeds Subtarget.getMaxLMULForFixedLengthVectors() * MinVLenInBytes, the memset should not be inlined. To determine whether inlining is profitable, llvm checks how many scalar stores would be required when using the widest scalar store type available on the target. On RV64, the widest scalar store type is i64, while on RV32 it is i32. Therefore, MaxStoresPerMemset should be computed differently depending on the target’s XLEN. |
||
| : Subtarget.getMaxStoresPerMemset(/*OptSize=*/false); | ||
|
|
||
| MaxGluedStoresPerMemcpy = Subtarget.getMaxGluedStoresPerMemcpy(); | ||
| MaxStoresPerMemcpyOptSize = Subtarget.getMaxStoresPerMemcpy(/*OptSize=*/true); | ||
|
|
@@ -23773,9 +23777,9 @@ bool RISCVTargetLowering::allowsMisalignedMemoryAccesses( | |
| return Subtarget.enableUnalignedVectorMem(); | ||
| } | ||
|
|
||
|
|
||
| EVT RISCVTargetLowering::getOptimalMemOpType(const MemOp &Op, | ||
| const AttributeList &FuncAttributes) const { | ||
| EVT RISCVTargetLowering::getOptimalMemOpType( | ||
| LLVMContext &Context, const MemOp &Op, | ||
| const AttributeList &FuncAttributes) const { | ||
| if (!Subtarget.hasVInstructions()) | ||
| return MVT::Other; | ||
|
|
||
|
|
@@ -23808,8 +23812,23 @@ EVT RISCVTargetLowering::getOptimalMemOpType(const MemOp &Op, | |
| // a large scalar constant and instead use vmv.v.x/i to do the | ||
| // broadcast. For everything else, prefer ELenVT to minimize VL and thus | ||
| // maximize the chance we can encode the size in the vsetvli. | ||
| MVT ELenVT = MVT::getIntegerVT(Subtarget.getELen()); | ||
| MVT PreferredVT = (Op.isMemset() && !Op.isZeroMemset()) ? MVT::i8 : ELenVT; | ||
| // If Op size is greater than LMUL8 memory operation, we don't support inline | ||
| // of memset. Return EVT based on Op size to avoid redundant splitting and | ||
| // merging operations if Op size is no greater than LMUL8 memory operation. | ||
| if (Op.isMemset()) { | ||
| if (!Op.isZeroMemset()) | ||
| return EVT::getVectorVT(Context, MVT::i8, Op.size()); | ||
| if (Op.size() > | ||
| Subtarget.getMaxLMULForFixedLengthVectors() * MinVLenInBytes) | ||
| return MVT::Other; | ||
| if (Subtarget.hasVInstructionsI64() && Op.size() % 8 == 0) | ||
| return EVT::getVectorVT(Context, MVT::i64, Op.size() / 8); | ||
topperc marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| if (Op.size() % 4 == 0) | ||
| return EVT::getVectorVT(Context, MVT::i32, Op.size() / 4); | ||
| return EVT::getVectorVT(Context, MVT::i8, Op.size()); | ||
| } | ||
|
|
||
| MVT PreferredVT = MVT::getIntegerVT(Subtarget.getELen()); | ||
|
|
||
| // Do we have sufficient alignment for our preferred VT? If not, revert | ||
| // to largest size allowed by our alignment criteria. | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.