Skip to content

Try adding Github Problem Matchers to libc++ workflow. #146768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Try adding Github Problem Matchers to libc++ workflow. #146768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92ccb58
Try adding Github Problem Matchers to libc++ workflow.
EricWF Jul 2, 2025
180f46c
Temporarily add a test failure to demonstrate the matchers in action.
EricWF Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/libcxx-problem-matchers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"problemMatcher": [
{
"owner": "clang",
"pattern": [
{
"regexp": "^(.+):(\\d+):(\\d+):\\s+(error|warning):\\s+(.+)$",
"file": 1,
"line": 2,
"column": 3,
"severity": 4,
"message": 5
}
]
},
{
"owner": "lit",
"severity": "error",
"pattern": [
{
"regexp": "^\\s*(FAIL|XPASS):\\s+([^\\s]+)\\s+::\\s+(.+?)\\s+\\(\\d+\\s+of\\s+\\d+\\)$",
"message": 2
}
]
}
]
}
28 changes: 25 additions & 3 deletions .github/workflows/libcxx-build-and-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,17 @@ jobs:
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- name: ${{ matrix.config }}.${{ matrix.cxx }}
run: libcxx/utils/ci/run-buildbot ${{ matrix.config }}
run: |
echo "::add-matcher::.github/libcxx-problem-matchers.json"
libcxx/utils/ci/run-buildbot ${{ matrix.config }}
env:
CC: ${{ matrix.cc }}
CXX: ${{ matrix.cxx }}
- if: always()
name: Disable Problem Matchers
run: |
echo "::remove-matcher owner=lit::"
echo "::remove-matcher owner=clang::"
- uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0
if: always()
with:
Expand Down Expand Up @@ -103,10 +110,17 @@ jobs:
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- name: ${{ matrix.config }}
run: libcxx/utils/ci/run-buildbot ${{ matrix.config }}
run: |
echo "::add-matcher::.github/libcxx-problem-matchers.json"
libcxx/utils/ci/run-buildbot ${{ matrix.config }}
env:
CC: ${{ matrix.cc }}
CXX: ${{ matrix.cxx }}
- if: always()
name: Disable Problem Matchers
run: |
echo "::remove-matcher owner=lit::"
echo "::remove-matcher owner=clang::"
- uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0
if: always() # Upload artifacts even if the build or test suite fails
with:
Expand Down Expand Up @@ -167,10 +181,17 @@ jobs:
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- name: ${{ matrix.config }}
run: libcxx/utils/ci/run-buildbot ${{ matrix.config }}
run: |
echo "::add-matcher::.github/libcxx-problem-matchers.json"
libcxx/utils/ci/run-buildbot ${{ matrix.config }}
env:
CC: clang-21
CXX: clang++-21
- if: always()
name: Disable Problem Matchers
run: |
echo "::remove-matcher owner=lit::"
echo "::remove-matcher owner=clang::"
- uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0
if: always()
with:
Expand Down Expand Up @@ -221,6 +242,7 @@ jobs:
- uses: seanmiddleditch/gha-setup-ninja@3b1f8f94a2f8254bd26914c4ab9474d4f0015f67 # v6
- name: Build and test
run: |
echo "::add-matcher::.github/libcxx-problem-matchers.json"
python3 -m venv .venv
source .venv/bin/activate
python -m pip install psutil
Expand Down
4 changes: 4 additions & 0 deletions libcxx/test/broken-on-purpose-1.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

DoesNotExist bar() {

}
Loading