-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[Win][X86]Fix issue where _fltused reference is incorrectly issued for vector floating point operations #146792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| ; The purpose of this test to verify that the fltused symbol is | ||
| ; not emitted when purely vector floating point operations are used on Windows. | ||
|
|
||
| ; RUN: llc < %s -mtriple i686-pc-win32 | FileCheck %s --check-prefix WIN32 | ||
| ; RUN: llc < %s -mtriple x86_64-pc-win32 | FileCheck %s --check-prefix WIN64 | ||
| ; RUN: llc < %s -O0 -mtriple i686-pc-win32 | FileCheck %s --check-prefix WIN32 | ||
| ; RUN: llc < %s -O0 -mtriple x86_64-pc-win32 | FileCheck %s --check-prefix WIN64 | ||
|
|
||
| @foo = external dso_local global [4 x float], align 16 | ||
|
|
||
| ; Function Attrs: noinline nounwind optnone sspstrong uwtable | ||
| define dso_local <4 x float> @func() #0 { | ||
| entry: | ||
| %__p.addr.i = alloca ptr, align 8 | ||
| %vector1 = alloca <4 x float>, align 16 | ||
| store ptr @foo, ptr %__p.addr.i, align 8 | ||
| %0 = load ptr, ptr %__p.addr.i, align 8 | ||
| %1 = load <4 x float>, ptr %0, align 16 | ||
| store <4 x float> %1, ptr %vector1, align 16 | ||
| %2 = load <4 x float>, ptr %vector1, align 16 | ||
| ret <4 x float> %2 | ||
| } | ||
|
|
||
| define <4 x float> @mul_vectors(<4 x float> %a, <4 x float> %b) { | ||
| entry: | ||
| %result = fmul <4 x float> %a, %b | ||
| ret <4 x float> %result | ||
| } | ||
|
|
||
| ; _fltused is determined at a module level | ||
| ; WIN32-NOT: .globl __fltused | ||
| ; WIN64-NOT: .globl _fltused | ||
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to test O0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Carry over from other test.