[lldb][mcp] Skip MCPUnixSocketCommandTestCase if remote

[aperez]

It looks like #146603 broke the lldb-remote-linux-win build bot because MCPUnixSocketCommandTestCase is trying to start a protocol-server via unix domain sockets on windows.
This change makes it so the test is skipped if it is remote.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Alexandre Perez (aperez)

Changes

It looks like #146603 broke the lldb-remote-linux-win build bot because MCPUnixSocketCommandTestCase is trying to start a protocol-server via unix domain sockets on windows.
This change makes it so the test is skipped if it is remote.

---

Full diff: https://github.com/llvm/llvm-project/pull/146807.diff

1 Files Affected:

• (modified) lldb/test/API/commands/protocol/TestMCPUnixSocket.py (+1)

diff --git a/lldb/test/API/commands/protocol/TestMCPUnixSocket.py b/lldb/test/API/commands/protocol/TestMCPUnixSocket.py
index de0aec040695f..ea9255cc60ef5 100644
--- a/lldb/test/API/commands/protocol/TestMCPUnixSocket.py
+++ b/lldb/test/API/commands/protocol/TestMCPUnixSocket.py
@@ -12,6 +12,7 @@
 
 class MCPUnixSocketCommandTestCase(TestBase):
     @skipIfWindows
+    @skipIfRemote
     @no_debug_info_test
     def test_unix_socket(self):
         """

[slydiman]

Please land it ASAP.

[labath]

I think you're looking for @skipIf(hostoslist=["windows"])

[slydiman]

I think you're looking for @skipIf(hostoslist=["windows"])

Yes, it looks more correct. But can a Unix socket be used for a remote connection?

[labath]

It cannot. However, the MCP connection is done locally (on the machine running lldb). You could argue @skipIfRemote is still a good thing because remote testing is not useful here (you could use the protocol to drive a remote debug session, but for most purposes the two sessions should behave the same way and this is hardly the right way to test that), but checking the host os is still the right thing to do.