Skip to content

Conversation

@kazutakahirata
Copy link
Contributor

Mem is already of uint8_t *.

@llvmbot
Copy link
Member

llvmbot commented Jul 3, 2025

@llvm/pr-subscribers-debuginfo

@llvm/pr-subscribers-platform-windows

Author: Kazu Hirata (kazutakahirata)

Changes

Mem is already of uint8_t *.


Full diff: https://github.com/llvm/llvm-project/pull/146809.diff

1 Files Affected:

  • (modified) llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp (+1-1)
diff --git a/llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp b/llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp
index 09cb355ca7319..c9a1eebb8a854 100644
--- a/llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp
+++ b/llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp
@@ -119,7 +119,7 @@ static CVSymbol serializePublic(uint8_t *Mem, const BulkPublic &Pub) {
   memcpy(NameMem, Pub.Name, NameLen);
   // Zero the null terminator and remaining bytes.
   memset(&NameMem[NameLen], 0, Size - sizeof(PublicSym32Layout) - NameLen);
-  return CVSymbol(ArrayRef(reinterpret_cast<uint8_t *>(Mem), Size));
+  return CVSymbol(ArrayRef(Mem, Size));
 }
 
 uint32_t GSIHashStreamBuilder::calculateSerializedLength() const {

@kazutakahirata kazutakahirata force-pushed the cleanup_20250702_cast_llvm_DebugInfo branch from 7c183b9 to 75ae02c Compare July 3, 2025 06:27
Mem is already of uint8_t *.
@kazutakahirata kazutakahirata force-pushed the cleanup_20250702_cast_llvm_DebugInfo branch from 75ae02c to 467b508 Compare July 3, 2025 15:29
@kazutakahirata kazutakahirata merged commit 4cd9c89 into llvm:main Jul 3, 2025
9 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_20250702_cast_llvm_DebugInfo branch July 3, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants