Skip to content

Conversation

@nikic
Copy link
Contributor

@nikic nikic commented Jul 3, 2025

Add abbreviations for icmp/fcmp, store and br, which are the most common instructions that don't have abbreviations yet. This requies increasing the abbreviation size to 5 bits.

This gives about 3-5% bitcode size reductions for the clang build: https://llvm-compile-time-tracker.com/compare_clang.php?from=d74d4ffa3342a97bcdfceae75616c755f83b3ca2&to=e8e45c235a7cd99269f45b86114245cca5da3dd8&stat=size-file&sortBy=absolute-difference

Add abbreviations for icmp/fcmp, store and br, which are the most
common instructions that don't have abbreviations yet. This requies
increasing the abbreviation size to 5 bits.

This gives about 3-5% bitcode size reductions for the clang build:
https://llvm-compile-time-tracker.com/compare_clang.php?from=d74d4ffa3342a97bcdfceae75616c755f83b3ca2&to=e8e45c235a7cd99269f45b86114245cca5da3dd8&stat=size-file&sortBy=absolute-difference
@nikic nikic requested review from OCHyams and dwblaikie July 3, 2025 07:27
@github-actions
Copy link

github-actions bot commented Jul 3, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

Copy link
Contributor

@OCHyams OCHyams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikic nikic merged commit 0a656d8 into llvm:main Jul 3, 2025
8 of 9 checks passed
@nikic nikic deleted the bitcode-abbrevs branch July 3, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants