Skip to content

[NFC] [C++] [Modules] Mark P1979 as implemented and add test #146841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025
Merged

[NFC] [C++] [Modules] Mark P1979 as implemented and add test #146841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4463daf
add test for P1979 to prove correctness
kish1n Jul 3, 2025
e085719
remove comment
kish1n Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions clang/test/SemaCXX/P1979.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
// RUN: rm -rf %t
// RUN: split-file %s %t


// RUN: %clang_cc1 -std=c++20 -verify -emit-module-interface %t/A.cpp -o %t/A.pcm
// RUN: %clang_cc1 -std=c++20 -verify -emit-module-interface %t/myV.cpp -o %t/myV.pcm
// RUN: %clang_cc1 -std=c++20 -verify -emit-module-interface -fmodule-file=V=%t/myV.pcm %t/partition.cpp -o %t/partition.pcm
// RUN: %clang_cc1 -std=c++20 -fsyntax-only -verify -fmodule-file=V=%t/myV.pcm -fmodule-file=A=%t/A.pcm -fmodule-file=A:partition=%t/partition.pcm %t/interface.cpp

//--- A.cpp
// expected-no-diagnostics
export module A;

//--- myV.cpp
// expected-no-diagnostics
export module V;

export struct myV{};

//--- uses_vector.h
// expected-no-diagnostics
#ifndef x
#define x

import V;
#endif

//--- partition.cpp
// expected-no-diagnostics
module;
#include "uses_vector.h" // textually expands to import V;
module A:partition;

//--- interface.cpp
module A;
import :partition;
myV V; // expected-error {{declaration of 'myV' must be imported from module 'V' before it is required}}
// [email protected]:4 {{declaration here is not visible}}
2 changes: 1 addition & 1 deletion clang/www/cxx_status.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,7 @@ <h2 id="cxx20">C++20 implementation status</h2>
</tr>
<tr> <!-- from Belfast -->
<td><a href="https://wg21.link/p1979r0">P1979R0</a></td>
<td class="none" align="center">No</td>
<td class="full" align="center">Clang 17</td>
</tr>
<tr> <!-- from Prague -->
<td><a href="https://wg21.link/p1779r3">P1779R3</a></td>
Expand Down
Loading