Skip to content

Conversation

@antoniofrighetto
Copy link
Contributor

Outdated pointee-type phrasings in ABI attributes have been removed.

@antoniofrighetto antoniofrighetto requested review from arsenm and nikic July 3, 2025 10:20
@llvmbot llvmbot added the llvm:ir label Jul 3, 2025
@llvmbot
Copy link
Member

llvmbot commented Jul 3, 2025

@llvm/pr-subscribers-llvm-ir

Author: Antonio Frighetto (antoniofrighetto)

Changes

Outdated pointee-type phrasings in ABI attributes have been removed.


Full diff: https://github.com/llvm/llvm-project/pull/146846.diff

1 Files Affected:

  • (modified) llvm/docs/LangRef.rst (+5-9)
diff --git a/llvm/docs/LangRef.rst b/llvm/docs/LangRef.rst
index 2a45f4f2dac47..0ac43106bf420 100644
--- a/llvm/docs/LangRef.rst
+++ b/llvm/docs/LangRef.rst
@@ -1234,8 +1234,7 @@ Currently, only the following parameter attributes are defined:
     ``byval`` parameters). This is not a valid attribute for return
     values.
 
-    The byval type argument indicates the in-memory value type, and
-    must be the same as the pointee type of the argument.
+    The byval type argument indicates the in-memory value type.
 
     The byval attribute also supports specifying an alignment with the
     align attribute. It indicates the alignment of the stack slot to
@@ -1283,8 +1282,7 @@ Currently, only the following parameter attributes are defined:
     any parameter must have a ``"preallocated"`` operand bundle. A ``musttail``
     function call cannot have a ``"preallocated"`` operand bundle.
 
-    The preallocated attribute requires a type argument, which must be
-    the same as the pointee type of the argument.
+    The preallocated attribute requires a type argument.
 
     The preallocated attribute also supports specifying an alignment with the
     align attribute. It indicates the alignment of the stack slot to
@@ -1318,8 +1316,7 @@ Currently, only the following parameter attributes are defined:
     must be cleared off with :ref:`llvm.stackrestore
     <int_stackrestore>`.
 
-    The inalloca attribute requires a type argument, which must be the
-    same as the pointee type of the argument.
+    The inalloca attribute requires a type argument.
 
     See :doc:`InAlloca` for more information on how to use this
     attribute.
@@ -1331,8 +1328,7 @@ Currently, only the following parameter attributes are defined:
     loads and stores to the structure may be assumed by the callee not
     to trap and to be properly aligned.
 
-    The sret type argument specifies the in memory type, which must be
-    the same as the pointee type of the argument.
+    The sret type argument specifies the in memory type.
 
     A function that accepts an ``sret`` argument must return ``void``.
     A return value may not be ``sret``.
@@ -13178,7 +13174,7 @@ This instruction requires several arguments:
    -  All ABI-impacting function attributes, such as sret, byval, inreg,
       returned, and inalloca, must match.
    -  The caller and callee prototypes must match. Pointer types of parameters
-      or return types may differ in pointee type, but not in address space.
+      or return types do not differ in address space.
 
    On the other hand, if the calling convention is `swifttailcc` or `tailcc`:
 

@antoniofrighetto antoniofrighetto force-pushed the feature/langref-drop-type-comment branch from 87451fb to 294696e Compare July 3, 2025 11:01
Outdated pointee-type phrasings in ABI attributes have been removed.
@antoniofrighetto antoniofrighetto force-pushed the feature/langref-drop-type-comment branch from 294696e to a2505cf Compare July 3, 2025 11:04
@antoniofrighetto antoniofrighetto merged commit a2505cf into llvm:main Jul 3, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants