Skip to content

[llvm] Use range-based for loops (NFC) #146945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2025
Merged

[llvm] Use range-based for loops (NFC) #146945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9c5ec6
[llvm] Use range-based for loops (NFC)
kazutakahirata Jul 3, 2025
197a5e2
Address a comment.
kazutakahirata Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/lib/Target/M68k/M68kInstrInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ bool M68kInstrInfo::AnalyzeBranchImpl(MachineBasicBlock &MBB,
// Erase any instructions if allowed at the end of the scope.
std::vector<std::reference_wrapper<llvm::MachineInstr>> EraseList;
auto FinalizeOnReturn = llvm::make_scope_exit([&EraseList] {
std::for_each(EraseList.begin(), EraseList.end(),
[](auto &ref) { ref.get().eraseFromParent(); });
for (auto &Ref : EraseList)
Ref.get().eraseFromParent();
});

// Start from the bottom of the block and work up, examining the
Expand Down
8 changes: 4 additions & 4 deletions llvm/lib/Transforms/Coroutines/SpillUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,10 +552,10 @@ void sinkSpillUsesAfterCoroBegin(const DominatorTree &Dom,
Worklist.push_back(Inst);
}
};
std::for_each(Spills.begin(), Spills.end(),
[&](auto &I) { collectUsers(I.first); });
std::for_each(Allocas.begin(), Allocas.end(),
[&](auto &I) { collectUsers(I.Alloca); });
for (auto &I : Spills)
collectUsers(I.first);
for (auto &I : Allocas)
collectUsers(I.Alloca);

// Recursively collect users before coro.begin.
while (!Worklist.empty()) {
Expand Down