Skip to content

[mlir] Use range-based for loops (NFC) #146946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2025
Merged

[mlir] Use range-based for loops (NFC) #146946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6353c5c
[mlir] Use range-based for loops (NFC)
kazutakahirata Jul 3, 2025
1b871bf
Address a comment.
kazutakahirata Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mlir/lib/Dialect/Mesh/Transforms/ShardingPropagation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ static llvm::raw_ostream &operator<<(llvm::raw_ostream &stream,
template <typename Stream, typename Range>
static Stream &printRange(Stream &stream, Range &&range) {
stream << "[";
llvm::for_each(range, [&stream](auto &v) {
for (auto &v : range) {
stream << v;
stream << ", ";
});
}
return stream << "]";
}

Expand Down
3 changes: 1 addition & 2 deletions mlir/lib/Dialect/Tosa/Transforms/TosaReduceTransposes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,8 +602,7 @@ void TosaReduceTransposes::runOnOperation() {
!llvm::isa<RankedTensorType>(output.getType()))
return;

llvm::for_each(transposeOp.getPerms(),
[&perms](const auto i) { perms.emplace_back(i); });
llvm::append_range(perms, transposeOp.getPerms());

// We let --canonicalize deal with identity transpose.
if (llvm::equal(llvm::seq<int32_t>(0, perms.size()), perms))
Expand Down
3 changes: 1 addition & 2 deletions mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,8 @@ void DefGen::createParentWithTraits() {
? cast<NativeTrait>(&trait)->getFullyQualifiedTraitName()
: cast<InterfaceTrait>(&trait)->getFullyQualifiedTraitName();
}));
llvm::for_each(traitNames, [&](auto &traitName) {
for (auto &traitName : traitNames)
defParent.addTemplateParam(traitName);
});

// Add OpAsmInterface::Trait if we automatically generate mnemonic alias
// method.
Expand Down