Skip to content

[Clang][NFC] Avoid copies by using std::move #146960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

[Clang][NFC] Avoid copies by using std::move #146960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions clang/include/clang/AST/Type.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6404,7 +6404,7 @@ class SpirvOperand {
SpirvOperand() : Kind(Invalid), ResultType(), Value() {}

SpirvOperand(SpirvOperandKind Kind, QualType ResultType, llvm::APInt Value)
: Kind(Kind), ResultType(ResultType), Value(Value) {}
: Kind(Kind), ResultType(ResultType), Value(std::move(Value)) {}

SpirvOperand(const SpirvOperand &Other) { *this = Other; }
~SpirvOperand() {}
Expand Down Expand Up @@ -6438,11 +6438,11 @@ class SpirvOperand {
}

static SpirvOperand createConstant(QualType ResultType, llvm::APInt Val) {
return SpirvOperand(ConstantId, ResultType, Val);
return SpirvOperand(ConstantId, ResultType, std::move(Val));
}

static SpirvOperand createLiteral(llvm::APInt Val) {
return SpirvOperand(Literal, QualType(), Val);
return SpirvOperand(Literal, QualType(), std::move(Val));
}

static SpirvOperand createType(QualType T) {
Expand Down
6 changes: 2 additions & 4 deletions clang/lib/CodeGen/Targets/SPIR.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,14 +421,12 @@ static llvm::Type *getInlineSpirvType(CodeGenModule &CGM,
case SpirvOperandKind::ConstantId: {
llvm::Type *IntegralType =
CGM.getTypes().ConvertType(Operand.getResultType());
llvm::APInt Value = Operand.getValue();

Result = getInlineSpirvConstant(CGM, IntegralType, Value);
Result = getInlineSpirvConstant(CGM, IntegralType, Operand.getValue());
break;
}
case SpirvOperandKind::Literal: {
llvm::APInt Value = Operand.getValue();
Result = getInlineSpirvConstant(CGM, nullptr, Value);
Result = getInlineSpirvConstant(CGM, nullptr, Operand.getValue());
break;
}
case SpirvOperandKind::TypeId: {
Expand Down
Loading