[BranchFolding] Add an optional target hook to skip branch folding when it's unsafe #147029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume the indirect branch implementation is as follows:
Here, the base address and offset are stored in
r0andr1respectively, withr2 = r1 + r0as the jump target. Analyzing the target of the indirect branchjris often challenging, particularly when registerr2is spilled.When basic block
BB0is empty,BranchFoldingmay optimize it, causing a dangling label. To address this, the target can overrideisMBBSafeToBranchFoldingand returnfalse.This issue was found in an out-of-tree target, hence the lack of testcase in this commit.