Skip to content

[Clang] accept @tparam on variable template partial specializations #147219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a-tarasyuk merged 3 commits into from
Jul 7, 2025
Merged

[Clang] accept @tparam on variable template partial specializations #147219

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5e5e79
[Clang] accept @tparam on variable template partial specializations
a-tarasyuk Jul 6, 2025
c487679
use auto instead of an explicit type
a-tarasyuk Jul 7, 2025
8710666
Merge branch 'main' into fix/144775
a-tarasyuk Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions clang/docs/ReleaseNotes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,6 +671,8 @@ Improvements to Clang's diagnostics
false positives in exception-heavy code, though only simple patterns
are currently recognized.

- Clang now accepts ``@tparam`` comments on variable template partial
specializations. (#GH144775)

Improvements to Clang's time-trace
----------------------------------
Expand Down
8 changes: 8 additions & 0 deletions clang/lib/AST/Comment.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,14 @@ void DeclInfo::fill() {
TemplateParameters = CTPSD->getTemplateParameters();
break;
}
case Decl::VarTemplatePartialSpecialization: {
const VarTemplatePartialSpecializationDecl *VTPSD =
cast<VarTemplatePartialSpecializationDecl>(CommentDecl);
Kind = VariableKind;
TemplateKind = TemplatePartialSpecialization;
TemplateParameters = VTPSD->getTemplateParameters();
break;
}
case Decl::ClassTemplateSpecialization:
Kind = ClassKind;
TemplateKind = TemplateSpecialization;
Expand Down
12 changes: 12 additions & 0 deletions clang/test/Sema/warn-documentation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1524,3 +1524,15 @@ F &f = FF; ///< \return none
// expected-warning@-1 {{'\return' command used in a comment that is not attached to a function or method declaration}}

} // namespace PR42844

#if __cplusplus >= 201402L
namespace GH144775 {
/// @brief primary template
/// @tparam T type
template <class T, class = void> constexpr auto var = T{};

/// @brief variable template partial specialization
/// @tparam T type
template <typename T> constexpr auto var<T> = T{};
} // namespace GH144775
#endif
Loading