Skip to content

[ADT] Implement ArrayRef::operator< and other comparisons #147277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jayfoad merged 1 commit into from
Jul 8, 2025
Merged

[ADT] Implement ArrayRef::operator< and other comparisons #147277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions llvm/include/llvm/ADT/ArrayRef.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,27 @@ namespace llvm {
return !(LHS == RHS);
}

template <typename T>
inline bool operator<(ArrayRef<T> LHS, ArrayRef<T> RHS) {
return std::lexicographical_compare(LHS.begin(), LHS.end(), RHS.begin(),
RHS.end());
}

template <typename T>
inline bool operator>(ArrayRef<T> LHS, ArrayRef<T> RHS) {
return RHS < LHS;
}

template <typename T>
inline bool operator<=(ArrayRef<T> LHS, ArrayRef<T> RHS) {
return !(LHS > RHS);
}

template <typename T>
inline bool operator>=(ArrayRef<T> LHS, ArrayRef<T> RHS) {
return !(LHS < RHS);
}

/// @}

template <typename T> hash_code hash_value(ArrayRef<T> S) {
Expand Down
21 changes: 21 additions & 0 deletions llvm/unittests/ADT/ArrayRefTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,27 @@ TEST(ArrayRefTest, EmptyEquals) {
EXPECT_TRUE(ArrayRef<unsigned>() == ArrayRef<unsigned>());
}

TEST(ArrayRefTest, Compare) {
ArrayRef<char> Ban("Ban");
ArrayRef<char> Banana("Banana");
ArrayRef<char> Band("Band");

EXPECT_TRUE(Ban < Banana);
EXPECT_TRUE(Ban <= Banana);
EXPECT_FALSE(Ban > Banana);
EXPECT_FALSE(Ban >= Banana);

EXPECT_FALSE(Banana < Banana);
EXPECT_TRUE(Banana <= Banana);
EXPECT_FALSE(Banana > Banana);
EXPECT_TRUE(Banana >= Banana);

EXPECT_TRUE(Banana < Band);
EXPECT_TRUE(Banana <= Band);
EXPECT_FALSE(Banana > Band);
EXPECT_FALSE(Banana >= Band);
}

TEST(ArrayRefTest, ConstConvert) {
int buf[4];
for (int i = 0; i < 4; ++i)
Expand Down
Loading