[libc] Add atexit to baremetal entrypoints #147290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-libc Author: William Huynh (saturn691) ChangesPart of #145349. Requires #145358. Required by #146863. Once the mutex has been implemented, we can register functions to be called for exit with Full diff: https://github.com/llvm/llvm-project/pull/147290.diff 3 Files Affected:
diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt
index a8e653fdd5159..4c1b33a7b1c0e 100644
--- a/libc/config/baremetal/aarch64/entrypoints.txt
+++ b/libc/config/baremetal/aarch64/entrypoints.txt
@@ -218,6 +218,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.stdlib.abort
libc.src.stdlib.abs
libc.src.stdlib.aligned_alloc
+ libc.src.stdlib.atexit
libc.src.stdlib.atof
libc.src.stdlib.atoi
libc.src.stdlib.atol
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index acafef17fa5d1..61a61f02c2095 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -218,6 +218,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.stdlib.abort
libc.src.stdlib.abs
libc.src.stdlib.aligned_alloc
+ libc.src.stdlib.atexit
libc.src.stdlib.atof
libc.src.stdlib.atoi
libc.src.stdlib.atol
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index 023826f12d723..758d5fe4c3e21 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -218,6 +218,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.stdlib.abort
libc.src.stdlib.abs
libc.src.stdlib.aligned_alloc
+ libc.src.stdlib.atexit
libc.src.stdlib.atof
libc.src.stdlib.atoi
libc.src.stdlib.atol
|
12 tasks
Contributor
michaelrj-google
left a comment
michaelrj-google
left a comment
There was a problem hiding this comment.
does atexit work on baremetal right now?
Contributor
Author
|
Not yet, but once we get #145358 merged we can enable it. |
vhscampos
approved these changes
Jul 21, 2025
Member
vhscampos
left a comment
vhscampos
left a comment
There was a problem hiding this comment.
LGTM as soon as the dependant changes are in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #145349. Requires #145358. Required by #146863. Once the mutex has been implemented, we can register functions to be called for exit with
atexit.