[AMDGPU][SDAG] Support source modifiers on select integer operands#147325

Closed

chrisjbris wants to merge 29 commits intollvm:mainfrom

chrisjbris:chrisjbris/integer_fneg_fabs

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[AMDGPU][SDAG] Support source modifiers on select integer operands#147325

[AMDGPU][SDAG] Support source modifiers on select integer operands#147325
chrisjbris wants to merge 29 commits intollvm:mainfrom
chrisjbris:chrisjbris/integer_fneg_fabs

Commits on Jul 12, 2025

Add new test for source modifiers on select

Populate check-lines before patching

[AMDGPU][SDAG] Support source modifiers as integer on select

Simplify switch in BitwiseToSrcModifierOp()

[NFC] Correct typo in BitwiseToSrcModifierOp()

Fix bitcast type in performSelectCombine()

Respond to first review comments

Respond to secon review comments - rename function and correct test

[NFC] Remove incomplete dag-style comment

Make test for bitwise src mods more stringent and correct fneg-fabs order

Reviewer corrections

Refactor to support the source modifiers on either or both operands.

Fix Typo.

Respond to reviewer - Add i16 tests, simplify obtaining type

Inline bitcast node creation.

Add functional implementation for i64

Fix formatting

Commits on Jul 13, 2025

[DAGCombine] Move the AMDGPU combine to Target Indepenent DAGCombine

Remove dead code that was moved to the TI DAGCombiner

Canonicalise TI select operand variable names and update tests

Fix missed clang-format

Suppress overzealous clang-format

Suppress overzealous clang-format

Remove unnecessary lambda and refactor foldSelectOfSourceMods() to fit TI DAGCombiner style.

[NFC] Minor corrections to whitespace and test name

Commits on Jul 14, 2025

Add tighter constraints to apply combine and update tests.

Further constrain shouldFoldSelectWithIdentityConstant(), preventing regressions

Fix broken insert-delay-alu-bug.ll test

Commits on Jul 15, 2025

Replace target-specific function names with target-independent names

[AMDGPU][SDAG] Support source modifiers on select integer operands#147325chrisjbris wants to merge 29 commits intollvm:mainllvm/llvm-project:mainfrom chrisjbris:chrisjbris/integer_fneg_fabschrisjbris/llvm-project:chrisjbris/integer_fneg_fabsCopy head branch name to clipboard

Commits

Commits on Jul 12, 2025

Commits on Jul 13, 2025

Commits on Jul 14, 2025

Commits on Jul 15, 2025

[AMDGPU][SDAG] Support source modifiers on select integer operands#147325
chrisjbris wants to merge 29 commits intollvm:mainfrom
chrisjbris:chrisjbris/integer_fneg_fabs