-
Notifications
You must be signed in to change notification settings - Fork 15.4k
[CI][Github] Enable CIR CI build and test #147430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
233b53a
[Github] Enable CIR CI build and test
andykaylor cbb524b
Fix formatting
andykaylor ac54157
Fix formatting again
andykaylor 5f6bda7
Update compute_projects_test.py
andykaylor a4ed027
Fix formatting
andykaylor 87cba17
Fix formatting yet again
andykaylor f1457f9
Defer mlir->cir testing dependency to a later change
andykaylor d95d66d
Address review feedback
andykaylor 8057127
Remove unnecessary changes
andykaylor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -104,6 +104,10 @@ def test_clang(self): | |
| env_variables["runtimes_check_targets_needs_reconfig"], | ||
| "check-cxx check-cxxabi check-unwind", | ||
| ) | ||
| self.assertEqual( | ||
| env_variables["enable_cir"], | ||
| "OFF", | ||
| ) | ||
|
|
||
| def test_clang_windows(self): | ||
| env_variables = compute_projects.get_env_variables( | ||
|
|
@@ -126,6 +130,32 @@ def test_clang_windows(self): | |
| env_variables["runtimes_check_targets_needs_reconfig"], | ||
| "check-cxx check-cxxabi check-unwind", | ||
| ) | ||
| self.assertEqual(env_variables["enable_cir"], "OFF") | ||
|
|
||
| def test_cir(self): | ||
| env_variables = compute_projects.get_env_variables( | ||
| ["clang/lib/CIR/CMakeLists.txt"], "Linux" | ||
| ) | ||
| self.assertEqual( | ||
| env_variables["projects_to_build"], | ||
| "clang;clang-tools-extra;lld;llvm;mlir", | ||
| ) | ||
| self.assertEqual( | ||
| env_variables["project_check_targets"], | ||
| "check-clang check-clang-cir check-clang-tools", | ||
| ) | ||
| self.assertEqual( | ||
| env_variables["runtimes_to_build"], "compiler-rt;libcxx;libcxxabi;libunwind" | ||
| ) | ||
| self.assertEqual( | ||
| env_variables["runtimes_check_targets"], | ||
| "check-compiler-rt", | ||
| ) | ||
| self.assertEqual( | ||
| env_variables["runtimes_check_targets_needs_reconfig"], | ||
| "check-cxx check-cxxabi check-unwind", | ||
| ) | ||
| self.assertEqual(env_variables["enable_cir"], "ON") | ||
|
|
||
| def test_bolt(self): | ||
| env_variables = compute_projects.get_env_variables( | ||
|
|
@@ -153,11 +183,13 @@ def test_mlir(self): | |
| ) | ||
| self.assertEqual(env_variables["projects_to_build"], "clang;flang;llvm;mlir") | ||
| self.assertEqual( | ||
| env_variables["project_check_targets"], "check-flang check-mlir" | ||
| env_variables["project_check_targets"], | ||
| "check-flang check-mlir", | ||
|
||
| ) | ||
| self.assertEqual(env_variables["runtimes_to_build"], "") | ||
| self.assertEqual(env_variables["runtimes_check_targets"], "") | ||
| self.assertEqual(env_variables["runtimes_check_targets_needs_reconfig"], "") | ||
| self.assertEqual(env_variables["enable_cir"], "ON") | ||
boomanaiden154 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| def test_flang(self): | ||
| env_variables = compute_projects.get_env_variables( | ||
|
|
@@ -168,6 +200,7 @@ def test_flang(self): | |
| self.assertEqual(env_variables["runtimes_to_build"], "") | ||
| self.assertEqual(env_variables["runtimes_check_targets"], "") | ||
| self.assertEqual(env_variables["runtimes_check_targets_needs_reconfig"], "") | ||
| self.assertEqual(env_variables["enable_cir"], "OFF") | ||
|
|
||
| def test_invalid_subproject(self): | ||
| env_variables = compute_projects.get_env_variables( | ||
|
|
@@ -237,7 +270,7 @@ def test_ci(self): | |
| ) | ||
| self.assertEqual( | ||
| env_variables["project_check_targets"], | ||
| "check-bolt check-clang check-clang-tools check-flang check-lld check-lldb check-llvm check-mlir check-polly", | ||
| "check-bolt check-clang check-clang-cir check-clang-tools check-flang check-lld check-lldb check-llvm check-mlir check-polly", | ||
| ) | ||
| self.assertEqual( | ||
| env_variables["runtimes_to_build"], | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this to avoid the temp variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I guess this is an artifact of my now-deleted change to remove CIR here.