[PS5][Driver] Fix bad negative check in ps5-linker.c test case #147484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regex used in a negative check had an unintended match with the pseudo-random part of the temporary directory created by a lit run on the SIE buildbot, causing a spurious test failure: https://lab.llvm.org/buildbot/#/builders/144/builds/29507 // CHECK-NO-CRT-NOT: crt{{[^"]*}}.o" ^ <stdin>:7:224: note: found here [...] "/tmp/lit-tmp-vcrtn3vi/ps5-linker-ee5f76.o" "-r" !~~~~~~~~~~~~~~~~~~~~~~~~~~ The updated check avoids such accidental matches.
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Edd Dawson (playstation-edd) ChangesA regex used in a negative check had an unintended match with the pseudo-random part of the temporary directory created by a lit run on the SIE buildbot, causing a spurious test failure: https://lab.llvm.org/buildbot/#/builders/144/builds/29507 The updated check avoids such accidental matches. Full diff: https://github.com/llvm/llvm-project/pull/147484.diff 1 Files Affected:
diff --git a/clang/test/Driver/ps5-linker.c b/clang/test/Driver/ps5-linker.c
index 753085d2e1b0b..16c9967bc2b41 100644
--- a/clang/test/Driver/ps5-linker.c
+++ b/clang/test/Driver/ps5-linker.c
@@ -165,7 +165,7 @@
// CHECK-SHARED-CRT-SAME: "-l:crtendS.o" "-l:crtn.o"
// CHECK-STATIC-CRT-SAME: "-l:crtend.o" "-l:crtn.o"
-// CHECK-NO-CRT-NOT: crt{{[^"]*}}.o"
+// CHECK-NO-CRT-NOT: "-l:crt
// CHECK-NO-LIBS-NOT: "-l{{[^"]*}}"
// Test the driver's control over the -fcrash-diagnostics-dir behavior with linker flags.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regex used in a negative check had an unintended match with the pseudo-random part of the temporary directory created by a lit run on the SIE buildbot, causing a spurious test failure:
https://lab.llvm.org/buildbot/#/builders/144/builds/29507
The updated check avoids such accidental matches.