Skip to content

Conversation

@frasercrmck
Copy link
Contributor

@frasercrmck frasercrmck commented Jul 8, 2025

This commit finishes the work started in #146840 and #147276. It makes each OpenCL header self-contained and each implementation file include only the headers it needs. It removes the need for a catch-all include file of all OpenCL builtin declarations.

This commit finishes the work started in llvm#146840 and llvm#147276. It makes
each OpenCL header self-contained and each implementation file include
only the header it needs. It removes the need for a catch-all include
file of all OpenCL builtin declarations.
@frasercrmck frasercrmck requested a review from wenju-he July 8, 2025 09:13
Copy link
Contributor

@wenju-he wenju-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frasercrmck frasercrmck merged commit 9d11bd0 into llvm:main Jul 8, 2025
10 checks passed
@frasercrmck frasercrmck deleted the libclc-opencl-base-final branch July 8, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants