Skip to content

Conversation

@tclin914
Copy link
Contributor

@tclin914 tclin914 commented Jul 8, 2025

I encountered the assertion failure Assertion TmpAsmInfo->getExceptionHandlingType() == getTargetTriple().getDefaultExceptionHandling() && "MCAsmInfo and Triple disagree on default exception handling type"' failed.

I encountered the assertion failure `Assertion `TmpAsmInfo->getExceptionHandlingType() == getTargetTriple().getDefaultExceptionHandling() && "MCAsmInfo and Triple disagree on default exception handling type"' failed`.
@tclin914 tclin914 requested a review from arsenm July 8, 2025 09:25
@llvmbot
Copy link
Member

llvmbot commented Jul 8, 2025

@llvm/pr-subscribers-backend-m68k

Author: Jim Lin (tclin914)

Changes

I encountered the assertion failure Assertion TmpAsmInfo->getExceptionHandlingType() == getTargetTriple().getDefaultExceptionHandling() && "MCAsmInfo and Triple disagree on default exception handling type"' failed.


Full diff: https://github.com/llvm/llvm-project/pull/147492.diff

2 Files Affected:

  • (modified) llvm/lib/TargetParser/Triple.cpp (+1)
  • (modified) llvm/unittests/TargetParser/TripleTest.cpp (+2)
diff --git a/llvm/lib/TargetParser/Triple.cpp b/llvm/lib/TargetParser/Triple.cpp
index 45ef8c1329759..0584c941d2e6e 100644
--- a/llvm/lib/TargetParser/Triple.cpp
+++ b/llvm/lib/TargetParser/Triple.cpp
@@ -2288,6 +2288,7 @@ ExceptionHandling Triple::getDefaultExceptionHandling() const {
   case Triple::csky:
   case Triple::hexagon:
   case Triple::lanai:
+  case Triple::m68k:
   case Triple::msp430:
   case Triple::systemz:
   case Triple::xcore:
diff --git a/llvm/unittests/TargetParser/TripleTest.cpp b/llvm/unittests/TargetParser/TripleTest.cpp
index 7817e82322963..ca48e77cf7caa 100644
--- a/llvm/unittests/TargetParser/TripleTest.cpp
+++ b/llvm/unittests/TargetParser/TripleTest.cpp
@@ -2832,6 +2832,8 @@ TEST(TripleTest, DefaultExceptionHandling) {
       Triple("loongarch64-unknown-unknown").getDefaultExceptionHandling());
   EXPECT_EQ(ExceptionHandling::DwarfCFI,
             Triple("msp430-unknown-unknown").getDefaultExceptionHandling());
+  EXPECT_EQ(ExceptionHandling::DwarfCFI,
+            Triple("m68k-unknown-unknown").getDefaultExceptionHandling());
   EXPECT_EQ(ExceptionHandling::DwarfCFI,
             Triple("csky-unknown-unknown").getDefaultExceptionHandling());
 

@tclin914 tclin914 merged commit 899a11a into llvm:main Jul 8, 2025
9 of 11 checks passed
@tclin914 tclin914 deleted the m68k-triple-assertion branch July 8, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants