[clang-tidy] support ak_attr_info in diagnostic forwarding

[a-tarasyuk]

This patch addresses missing support for forwarding ak_attr_info diagnostic arguments in ClangTidyDiagnosticConsumer

[llvmbot]

@llvm/pr-subscribers-clang-tools-extra

Author: Oleksandr T. (a-tarasyuk)

Changes

This patch addresses missing support for forwarding ak_attr_info diagnostic arguments in ClangTidyDiagnosticConsumer

---

Full diff: https://github.com/llvm/llvm-project/pull/147503.diff

1 Files Affected:

• (modified) clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp (+3)

diff --git a/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp b/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
index c35f0b941c600..f9d75978d0ea8 100644
--- a/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
+++ b/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
@@ -544,6 +544,9 @@ void ClangTidyDiagnosticConsumer::forwardDiagnostic(const Diagnostic &Info) {
     case clang::DiagnosticsEngine::ak_attr:
       Builder << reinterpret_cast<Attr *>(Info.getRawArg(Index));
       break;
+    case clang::DiagnosticsEngine::ak_attr_info:
+      Builder << reinterpret_cast<AttributeCommonInfo *>(Info.getRawArg(Index));
+      break;
     case clang::DiagnosticsEngine::ak_addrspace:
       Builder << static_cast<LangAS>(Info.getRawArg(Index));
       break;

[llvmbot]

@llvm/pr-subscribers-clang-tidy

Author: Oleksandr T. (a-tarasyuk)

Changes

This patch addresses missing support for forwarding ak_attr_info diagnostic arguments in ClangTidyDiagnosticConsumer

---

Full diff: https://github.com/llvm/llvm-project/pull/147503.diff

1 Files Affected:

• (modified) clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp (+3)

diff --git a/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp b/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
index c35f0b941c600..f9d75978d0ea8 100644
--- a/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
+++ b/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
@@ -544,6 +544,9 @@ void ClangTidyDiagnosticConsumer::forwardDiagnostic(const Diagnostic &Info) {
     case clang::DiagnosticsEngine::ak_attr:
       Builder << reinterpret_cast<Attr *>(Info.getRawArg(Index));
       break;
+    case clang::DiagnosticsEngine::ak_attr_info:
+      Builder << reinterpret_cast<AttributeCommonInfo *>(Info.getRawArg(Index));
+      break;
     case clang::DiagnosticsEngine::ak_addrspace:
       Builder << static_cast<LangAS>(Info.getRawArg(Index));
       break;

[mikaelholmen]

This solves the compilation warning/error I reported in
#144619 (comment)

[mikaelholmen]

LGTM since it solves the warning/error.

[vbvictor]

Did any of the builders caught this, or it is some local configuration?
Asking just in case if we should create one for catching such CE's.

[mikaelholmen]

Did any of the builders caught this, or it is some local configuration? Asking just in case if we should create one for catching such CE's.

I saw it locally when compiling with -Wall -Werror. I don't know if any builder use -Werror? I don't see any sign of it in #144619 at least.

[AaronBallman]

LGTM!