Skip to content

Conversation

@zibi2
Copy link
Contributor

@zibi2 zibi2 commented Jul 8, 2025

Number of threads on z/OS are controlled at the system level and thus we need to XFAIL this test.

@zibi2 zibi2 self-assigned this Jul 8, 2025
@zibi2 zibi2 requested a review from a team as a code owner July 8, 2025 13:22
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jul 8, 2025
@llvmbot
Copy link
Member

llvmbot commented Jul 8, 2025

@llvm/pr-subscribers-libcxx

Author: Zibi Sarbinowski (zibi2)

Changes

Number of threads on z/OS are controlled at the system level and thus we need to XFAIL this test.


Full diff: https://github.com/llvm/llvm-project/pull/147520.diff

1 Files Affected:

  • (modified) libcxx/test/std/thread/futures/futures.async/thread_create_failure.pass.cpp (+3)
diff --git a/libcxx/test/std/thread/futures/futures.async/thread_create_failure.pass.cpp b/libcxx/test/std/thread/futures/futures.async/thread_create_failure.pass.cpp
index 9ac54a8738662..4e087fd4226d1 100644
--- a/libcxx/test/std/thread/futures/futures.async/thread_create_failure.pass.cpp
+++ b/libcxx/test/std/thread/futures/futures.async/thread_create_failure.pass.cpp
@@ -21,6 +21,9 @@
 // XFAIL: target={{.+}}-apple-{{.*}}
 // XFAIL: freebsd
 
+// z/OS does not have mechanism to limit the number of threads
+// XFAIL: target={{.+}}-zos{{.*}}
+
 // This test makes sure that we fail gracefully in care the thread creation fails. This is only reliably possible on
 // systems that allow limiting the number of threads that can be created. See https://llvm.org/PR125428 for more details
 

Copy link
Contributor

@abhina-sree abhina-sree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zibi2 zibi2 merged commit bc8aa97 into llvm:main Jul 8, 2025
134 of 143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants