Skip to content

[NFCI][msan] Refactor to use 'isFixedIntVector' etc. #147789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

[NFCI][msan] Refactor to use 'isFixedIntVector' etc. #147789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4376,6 +4376,22 @@ struct MemorySanitizerVisitor : public InstVisitor<MemorySanitizerVisitor> {
setOriginForNaryOp(I);
}

[[maybe_unused]] static bool isFixedIntVectorTy(const Type *T) {
return isa<FixedVectorType>(T) && T->isIntOrIntVectorTy();
}

[[maybe_unused]] static bool isFixedFPVectorTy(const Type *T) {
return isa<FixedVectorType>(T) && T->isFPOrFPVectorTy();
}

[[maybe_unused]] static bool isFixedIntVector(const Value *V) {
return isFixedIntVectorTy(V->getType());
}

[[maybe_unused]] static bool isFixedFPVector(const Value *V) {
return isFixedFPVectorTy(V->getType());
}

// e.g., call <16 x i32> @llvm.x86.avx512.mask.cvtps2dq.512
// (<16 x float> a, <16 x i32> writethru, i16 mask,
// i32 rounding)
Expand All @@ -4393,11 +4409,8 @@ struct MemorySanitizerVisitor : public InstVisitor<MemorySanitizerVisitor> {
Value *Mask = I.getOperand(2);
[[maybe_unused]] Value *RoundingMode = I.getOperand(3);

assert(isa<FixedVectorType>(A->getType()));
assert(A->getType()->isFPOrFPVectorTy());

assert(isa<FixedVectorType>(WriteThrough->getType()));
assert(WriteThrough->getType()->isIntOrIntVectorTy());
assert(isFixedFPVector(A));
assert(isFixedIntVector(WriteThrough));

unsigned ANumElements =
cast<FixedVectorType>(A->getType())->getNumElements();
Expand Down Expand Up @@ -4617,11 +4630,8 @@ struct MemorySanitizerVisitor : public InstVisitor<MemorySanitizerVisitor> {
Value *WriteThrough = I.getOperand(1);
Value *Mask = I.getOperand(2);

assert(isa<FixedVectorType>(A->getType()));
assert(A->getType()->isIntOrIntVectorTy());

assert(isa<FixedVectorType>(WriteThrough->getType()));
assert(WriteThrough->getType()->isIntOrIntVectorTy());
assert(isFixedIntVector(A));
assert(isFixedIntVector(WriteThrough));

unsigned ANumElements =
cast<FixedVectorType>(A->getType())->getNumElements();
Expand Down
Loading