Skip to content

[libc++] Remove temporary XFAIL for Android CI again #147907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

philnik777
Copy link
Contributor

@philnik777 philnik777 commented Jul 10, 2025

The test has been XFAILed temporarily because the Clang version in the Android CI is too old. Once the Android CI is updated the XFAIL should be removed again.

@philnik777 philnik777 requested a review from a team as a code owner July 10, 2025 07:30
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jul 10, 2025
@llvmbot
Copy link
Member

llvmbot commented Jul 10, 2025

@llvm/pr-subscribers-libcxx

Author: Nikolas Klauser (philnik777)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/147907.diff

1 Files Affected:

  • (modified) libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/has_unique_object_representations.compile.pass.cpp (-3)
diff --git a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/has_unique_object_representations.compile.pass.cpp b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/has_unique_object_representations.compile.pass.cpp
index 9aac871f2633f..bd7da40daf2bc 100644
--- a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/has_unique_object_representations.compile.pass.cpp
+++ b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/has_unique_object_representations.compile.pass.cpp
@@ -8,9 +8,6 @@
 
 // UNSUPPORTED: c++03, c++11, c++14
 
-// The Clang version that Android currently uses in the CI is too old.
-// XFAIL: LIBCXX-ANDROID-FIXME
-
 // type_traits
 
 // has_unique_object_representations

@philnik777
Copy link
Contributor Author

@rprichard could you update the Android runners so we can drop this XFAIL again?

@ldionne
Copy link
Member

ldionne commented Jul 15, 2025

CC @enh-google

@pirama-arumuga-nainar
Copy link
Collaborator

Thanks for the changes to keep the CI green!

I am going to look it up, but in case you figured this out already, do you know which clang change caused the test to fail?

@rprichard
Copy link
Contributor

#148998 updates the Android compiler.

@philnik777 philnik777 closed this Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants