Skip to content

[Clang] Mark a concept as being invalid if the constraint is invalid #147938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ojhunt merged 1 commit into from
Jul 11, 2025
Merged

[Clang] Mark a concept as being invalid if the constraint is invalid #147938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion clang/lib/Sema/SemaTemplate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8968,8 +8968,10 @@ Sema::ActOnFinishConceptDefinition(Scope *S, ConceptDecl *C,
Expr *ConstraintExpr,
const ParsedAttributesView &Attrs) {
assert(!C->hasDefinition() && "Concept already defined");
if (DiagnoseUnexpandedParameterPack(ConstraintExpr))
if (DiagnoseUnexpandedParameterPack(ConstraintExpr)) {
C->setInvalidDecl();
return nullptr;
}
C->setDefinition(ConstraintExpr);
ProcessDeclAttributeList(S, C, Attrs);

Expand Down
14 changes: 14 additions & 0 deletions clang/test/SemaCXX/concept-crash-on-diagnostic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,17 @@ concept atomicish = requires() {
};
atomicish<int> f(); // expected-error {{expected 'auto' or 'decltype(auto)' after concept name}}
} // namespace GH138820

namespace GH138823 {
template <typename T> void foo();
template <class... Ts>
concept ConceptA = requires { foo<Ts>(); };
// expected-error@-1 {{expression contains unexpanded parameter pack 'Ts'}}

template <class>
concept ConceptB = ConceptA<int>;

template <ConceptB Foo> void bar(Foo);

void test() { bar(1); }
}
Loading