Skip to content

[clang] Fix isConstantInitializer handling of transparent init lists. #148030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 13, 2025
Merged

[clang] Fix isConstantInitializer handling of transparent init lists. #148030

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c27920
[clang] Fix isConstantInitializer handling of transparent init lists.
efriedma-quic Jul 10, 2025
dc1805e
Add relnote.
efriedma-quic Jul 11, 2025
638a883
Merge branch 'main' into is-constant-initializer-transparent-initlist
efriedma-quic Jul 11, 2025
56bae7f
Merge branch 'main' into is-constant-initializer-transparent-initlist
efriedma-quic Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions clang/lib/AST/Expr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3393,6 +3393,10 @@ bool Expr::isConstantInitializer(ASTContext &Ctx, bool IsForRef,
// an anonymous union, in declaration order.
const InitListExpr *ILE = cast<InitListExpr>(this);
assert(ILE->isSemanticForm() && "InitListExpr must be in semantic form");

if (ILE->isTransparent())
return ILE->getInit(0)->isConstantInitializer(Ctx, false, Culprit);

if (ILE->getType()->isArrayType()) {
unsigned numInits = ILE->getNumInits();
for (unsigned i = 0; i < numInits; i++) {
Expand Down
9 changes: 9 additions & 0 deletions clang/test/CodeGenCXX/const-init-cxx11.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,15 @@ struct PR69979 {
const char (&d)[9];
} e {"12345678"};

namespace GH147949 {
struct Coordinate {};
Coordinate Make();
void TestBody() {
// CHECK: call {{.*}} @_ZN8GH1479494MakeEv
const Coordinate x{Make()};
}
}

// VirtualMembers::TemplateClass::templateMethod() must be defined in this TU,
// not just declared.
// CHECK: define linkonce_odr void @_ZN14VirtualMembers13TemplateClassIiE14templateMethodEv(ptr {{[^,]*}} %this)
8 changes: 8 additions & 0 deletions clang/test/SemaCXX/compound-literal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,11 @@ int f();
#endif
Foo o = (Foo){ {}, 1, f() };
}

#if __cplusplus >= 201103L
namespace GH147949 {
// Make sure we handle transparent InitListExprs correctly.
struct S { int x : 3; };
const S* x = (const S[]){S{S{3}}};
}
#endif
Loading