AMDGPU: Remove "gws" feature from generic targets #148122
Conversation
Here "generic targets" means when no target is specified. This is bexause gfx12 does not have this festure, and thus it is no longer universally available. Fixes: SWDEV-541399
|
@llvm/pr-subscribers-backend-amdgpu Author: Changpeng Fang (changpeng) ChangesHere "generic targets" means when no target is specified. This is because gfx12+ does not support this feature, and thus it is no longer universally available. Fixes: SWDEV-541399 Full diff: https://github.com/llvm/llvm-project/pull/148122.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/GCNProcessors.td b/llvm/lib/Target/AMDGPU/GCNProcessors.td
index b5ffa64c3a4b4..217942c7e539c 100644
--- a/llvm/lib/Target/AMDGPU/GCNProcessors.td
+++ b/llvm/lib/Target/AMDGPU/GCNProcessors.td
@@ -9,11 +9,11 @@
// The code produced for "generic" is only useful for tests and cannot
// reasonably be expected to execute on any particular target.
def : ProcessorModel<"generic", NoSchedModel,
- [FeatureGDS, FeatureGWS]
+ [FeatureGDS]
>;
def : ProcessorModel<"generic-hsa", NoSchedModel,
- [FeatureGDS, FeatureGWS, FeatureFlatAddressSpace]
+ [FeatureGDS, FeatureFlatAddressSpace]
>;
//===------------------------------------------------------------===//
|
| // reasonably be expected to execute on any particular target. | ||
| def : ProcessorModel<"generic", NoSchedModel, | ||
| [FeatureGDS, FeatureGWS] | ||
| [FeatureGDS] |
There was a problem hiding this comment.
As a side note I'd remove one last feature. IMO generic shall be featureless.
There was a problem hiding this comment.
GDS was also removed, so it should also not be here. Not sure how it ended up here in the first place
There was a problem hiding this comment.
GDS was also removed, so it should also not be here. Not sure how it ended up here in the first place
I am going to remove it in a following patch. Additional work is to remove gds related LIT tests for amdgcn/amdhsa with no target.
There was a problem hiding this comment.
I'd even assert somewhere that feature mask for generic is zero.
There was a problem hiding this comment.
No tests should be removed. The tests should be moved to use an explicit target
There was a problem hiding this comment.
As a side note I'd remove one last feature. IMO generic shall be featureless.
Maybe we can keep FeatureFlatAddressSpace for generic-hsa to differentiate from generic.
There was a problem hiding this comment.
Tahiti is not the one to support it. No luck here. Technically it has it, but practically it does not. Unless we say it is not a hsa target, which it is not really.
There was a problem hiding this comment.
You can ignore FeatureFlatAddressSpace, it is irrelevant now. Just leave it alone
Here "generic targets" means when no target is specified. This is because gfx12+ does not support this feature, and thus it is no longer universally available. Fixes: SWDEV-541399 (cherry picked from commit edd615e)
4 participants
Here "generic targets" means when no target is specified. This is because gfx12+ does not support this feature, and thus it is no longer universally available.
Fixes: SWDEV-541399