[FIX] Fix sanitizer-aarch64-linux build after commit 8472eb1361bbabd6… #148206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-backend-aarch64 Author: Sergey Shcherbinin (SergeyShch01) ChangesThe previous commit 8472eb1 broke the sanitizer-aarch64-linux builder. This patch fixes it: unsued variable is removed Full diff: https://github.com/llvm/llvm-project/pull/148206.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp b/llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
index edbc3d8c3f614..e6b22695761e7 100644
--- a/llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
+++ b/llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
@@ -2569,7 +2569,6 @@ MachineBasicBlock::iterator AArch64LoadStoreOpt::findMatchingUpdateInsnForward(
// such that BaseReg is alive along it but not at its exits
MachineBasicBlock *SuccToVisit = nullptr;
unsigned LiveSuccCount = 0;
- MCRegister RegNoBAse = BaseReg;
for (MachineBasicBlock *Succ : CurMBB->successors()) {
for (MCRegAliasIterator AI(BaseReg, TRI, true); AI.isValid(); ++AI) {
if (Succ->isLiveIn(*AI)) {
|
Contributor
Author
|
@john-brawn-arm, I missed the unused variable in my prev commit ([AArch64LoadStoreOpt] BaseReg update is searched also in CF successor) - could you please approve/merge the fix? |
amirnd51
pushed a commit
to amirnd51/llvm-project
that referenced
this pull request
Jul 11, 2025
bonsthie
pushed a commit
to bonsthie/llvm-project
that referenced
this pull request
Jul 22, 2025
steven-studio
pushed a commit
to steven-studio/llvm-project
that referenced
this pull request
Sep 11, 2025
llvm#148206) The previous commit 7813f464666448512744b6073aa8af127f912c06 broke the sanitizer-aarch64-linux builder. This patch fixes it: unused variable is removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous commit 8472eb1 broke the sanitizer-aarch64-linux builder.
This patch fixes it: unused variable is removed