Skip to content

[LLDB][NVIDIA] Add Disassembler log channel #148290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025
Merged

[LLDB][NVIDIA] Add Disassembler log channel #148290

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5e8c92
[LLDB][NVIDIA] Add Disassembler log channel
agontarek Jul 11, 2025
a3c6103
[LLDB][NVIDIA] Update for review comments
agontarek Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lldb/include/lldb/Utility/LLDBLog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ enum class LLDBLog : Log::MaskType {
Watchpoints = Log::ChannelFlag<30>,
OnDemand = Log::ChannelFlag<31>,
Source = Log::ChannelFlag<32>,
Disassembler = Log::ChannelFlag<33>,
LLVM_MARK_AS_BITMASK_ENUM(OnDemand),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update this with the last enum. Someone forgot to do it when they added the Source enum. So this line should be:

LLVM_MARK_AS_BITMASK_ENUM(Disassembler),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Done.

};

Expand Down
2 changes: 1 addition & 1 deletion lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,7 +1146,7 @@ class InstructionLLVMC : public lldb_private::Instruction {
}
}

if (Log *log = GetLog(LLDBLog::Process)) {
if (Log *log = GetLog(LLDBLog::Disassembler)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have the option to specify multiple flag bits:

if (Log *log = GetLog(LLDBLog::Process  | LLDBLog::Disassembler)) {

We might want to add this to ensure that the logging behavior doesn't change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

StreamString ss;

ss.Printf("[%s] expands to %zu operands:\n", operands_string,
Expand Down
3 changes: 3 additions & 0 deletions lldb/source/Utility/LLDBLog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ static constexpr Log::Category g_categories[] = {
{"log symbol on-demand related activities"},
LLDBLog::OnDemand},
{{"source"}, {"log source related activities"}, LLDBLog::Source},
{{"disassembler"},
{"log disassembler related activities"},
LLDBLog::Disassembler},
};

static Log::Channel g_log_channel(g_categories,
Expand Down