[mlir][acc] Add MappableType API for generating private recipe init #148293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces the first in a series of APIs that will allow a MappableType to generate the body of the recipes. The current API does not actually generate the recipe itself - it generates the body of it. So it can either be placed in a recipe or inlined directly as needed.
|
@llvm/pr-subscribers-mlir Author: Razvan Lupusoru (razvanlupusoru) ChangesThis introduces the first in a series of APIs that will allow a MappableType to generate the body of the recipes. The current API does not actually generate the recipe itself - it generates the body of it. So it can either be placed in a recipe or inlined directly as needed. Full diff: https://github.com/llvm/llvm-project/pull/148293.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.td b/mlir/include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.td
index 9ff2507629856..b8602535296dd 100644
--- a/mlir/include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.td
+++ b/mlir/include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.td
@@ -180,6 +180,36 @@ def OpenACC_MappableTypeInterface : TypeInterface<"MappableType"> {
return ::mlir::acc::VariableTypeCategory::uncategorized;
}]
>,
+ InterfaceMethod<
+ /*description=*/[{
+ Generates the operations that would be normally placed in a recipe's
+ init region. It inserts at the builder's current location.
+ It can be used either to directly "inline" the init region
+ or if the caller sets the insertion point to inside a recipe body,
+ it fills it in. This does not generate the `acc.yield` that normally
+ would terminate a recipe.
+
+ The `extents` are optional and can be empty - it is only when a
+ slice of the private variable needs allocated.
+ The `initVal` can be empty - it is primarily needed for reductions
+ to ensure the variable is also initialized with appropriate value.
+
+ If the return value is empty, it means that recipe body was not
+ successfully generated.
+ }],
+ /*retTy=*/"::mlir::Value",
+ /*methodName=*/"generatePrivateInit",
+ /*args=*/(ins "::mlir::OpBuilder &":$builder,
+ "::mlir::Location":$loc,
+ "::mlir::TypedValue<::mlir::acc::MappableType>":$var,
+ "::llvm::StringRef":$varName,
+ "::mlir::ValueRange":$extents,
+ "::mlir::Value":$initVal),
+ /*methodBody=*/"",
+ /*defaultImplementation=*/[{
+ return {};
+ }]
+ >,
];
}
|
|
@llvm/pr-subscribers-mlir-openacc Author: Razvan Lupusoru (razvanlupusoru) ChangesThis introduces the first in a series of APIs that will allow a MappableType to generate the body of the recipes. The current API does not actually generate the recipe itself - it generates the body of it. So it can either be placed in a recipe or inlined directly as needed. Full diff: https://github.com/llvm/llvm-project/pull/148293.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.td b/mlir/include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.td
index 9ff2507629856..b8602535296dd 100644
--- a/mlir/include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.td
+++ b/mlir/include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.td
@@ -180,6 +180,36 @@ def OpenACC_MappableTypeInterface : TypeInterface<"MappableType"> {
return ::mlir::acc::VariableTypeCategory::uncategorized;
}]
>,
+ InterfaceMethod<
+ /*description=*/[{
+ Generates the operations that would be normally placed in a recipe's
+ init region. It inserts at the builder's current location.
+ It can be used either to directly "inline" the init region
+ or if the caller sets the insertion point to inside a recipe body,
+ it fills it in. This does not generate the `acc.yield` that normally
+ would terminate a recipe.
+
+ The `extents` are optional and can be empty - it is only when a
+ slice of the private variable needs allocated.
+ The `initVal` can be empty - it is primarily needed for reductions
+ to ensure the variable is also initialized with appropriate value.
+
+ If the return value is empty, it means that recipe body was not
+ successfully generated.
+ }],
+ /*retTy=*/"::mlir::Value",
+ /*methodName=*/"generatePrivateInit",
+ /*args=*/(ins "::mlir::OpBuilder &":$builder,
+ "::mlir::Location":$loc,
+ "::mlir::TypedValue<::mlir::acc::MappableType>":$var,
+ "::llvm::StringRef":$varName,
+ "::mlir::ValueRange":$extents,
+ "::mlir::Value":$initVal),
+ /*methodBody=*/"",
+ /*defaultImplementation=*/[{
+ return {};
+ }]
+ >,
];
}
|
|
@llvm/pr-subscribers-openacc Author: Razvan Lupusoru (razvanlupusoru) ChangesThis introduces the first in a series of APIs that will allow a MappableType to generate the body of the recipes. The current API does not actually generate the recipe itself - it generates the body of it. So it can either be placed in a recipe or inlined directly as needed. Full diff: https://github.com/llvm/llvm-project/pull/148293.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.td b/mlir/include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.td
index 9ff2507629856..b8602535296dd 100644
--- a/mlir/include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.td
+++ b/mlir/include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.td
@@ -180,6 +180,36 @@ def OpenACC_MappableTypeInterface : TypeInterface<"MappableType"> {
return ::mlir::acc::VariableTypeCategory::uncategorized;
}]
>,
+ InterfaceMethod<
+ /*description=*/[{
+ Generates the operations that would be normally placed in a recipe's
+ init region. It inserts at the builder's current location.
+ It can be used either to directly "inline" the init region
+ or if the caller sets the insertion point to inside a recipe body,
+ it fills it in. This does not generate the `acc.yield` that normally
+ would terminate a recipe.
+
+ The `extents` are optional and can be empty - it is only when a
+ slice of the private variable needs allocated.
+ The `initVal` can be empty - it is primarily needed for reductions
+ to ensure the variable is also initialized with appropriate value.
+
+ If the return value is empty, it means that recipe body was not
+ successfully generated.
+ }],
+ /*retTy=*/"::mlir::Value",
+ /*methodName=*/"generatePrivateInit",
+ /*args=*/(ins "::mlir::OpBuilder &":$builder,
+ "::mlir::Location":$loc,
+ "::mlir::TypedValue<::mlir::acc::MappableType>":$var,
+ "::llvm::StringRef":$varName,
+ "::mlir::ValueRange":$extents,
+ "::mlir::Value":$initVal),
+ /*methodBody=*/"",
+ /*defaultImplementation=*/[{
+ return {};
+ }]
+ >,
];
}
|
clementval
reviewed
Jul 11, 2025
clementval
approved these changes
Jul 11, 2025
Co-authored-by: Valentin Clement (バレンタイン クレメン) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the first in a series of APIs that will allow a MappableType to generate the body of the recipes. The current API does not actually generate the recipe itself - it generates the body of it. So it can either be placed in a recipe or inlined directly as needed.