Skip to content

Conversation

@jeaye
Copy link
Contributor

@jeaye jeaye commented Jul 14, 2025

There are two usability concerns, in some cases, with the new cloneToContext from #146852.

  1. This API assumes the LLVM context is in a ThreadSafeContext, but I have no need for that. My IR gen is single-threaded. IR gen (via IRBuilder) uses the context and module often, so I would need to do a whole lot of withContextDo with closures just to do things like create a new basic block.

  2. The new cloning function requires a ThreadSafeModule, which can only be constructed by moving (i.e. consuming) a module. This prevents me from caching my C++ modules, which explodes the number I need to generate. Cloning should be read-only, so the module consuming here feels like it's just an implication of TSMs being used.

We can address both of these by:

  1. Adding a getContextUnlocked to ThreadSafeContext, following what exists for ThreadSafeModule; this allows me to store a raw pointer for easy use with IR gen

  2. Add an overload for cloneToContext which take a const Module & and use that as the implementation for the TSM version

@lhames for vis.

@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant