Skip to content

[llvm-lto2] Added version command for llvm-lto2 #148866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 28, 2025
Merged

[llvm-lto2] Added version command for llvm-lto2 #148866

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
48ba0ed
Added version command for llvm-lto2
fnriv Jul 14, 2025
d220880
llvm-lto2: Changed version main command to --version
fnriv Jul 14, 2025
cf5ae9d
llvm-lto2 fixed usage description for commands
fnriv Jul 14, 2025
6440d77
Revised usage message
fnriv Jul 14, 2025
12f63e6
Merge branch 'llvm:main' into llvm-lto2-version
fnriv Jul 15, 2025
d59903a
Merge branch 'llvm:main' into llvm-lto2-version
fnriv Jul 15, 2025
1f81c2e
Merge branch 'main' into llvm-lto2-version
fnriv Aug 25, 2025
8f0e86d
Fixed syntax mistake on llvm-lto2 version.test
fnriv Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions llvm/test/tools/llvm-lto2/version.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
## Show that you can run version as a main command for llvm-lto2
## or a subcommand of llvm-lto2 run.

RUN: llvm-lto2 --version | Filecheck %s
RUN: llvm-lto2 run --version | FileCheck %s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest removing the support for emitting the version under the run subcommand, but I don't see it in llvm-lto2.cpp. Is that coming from somewhere in cl::ParseCommandLineOptions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Teresa,

It seems that llvm-lto2 run uses cl::ParseCommandLineOptions. This calls initCommonOptions() in CommandLine.cpp instantiates a CommandLineCommonOptions struct, where there is a VersionPrinter option and function. So taking it out or changing that workflow would impact other uses of cl::ParseCommandLineOptions.


CHECK: version
4 changes: 4 additions & 0 deletions llvm/tools/llvm-lto2/llvm-lto2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,5 +616,9 @@ int main(int argc, char **argv) {
outs() << GlobalValue::getGUIDAssumingExternalLinkage(argv[2]) << '\n';
return 0;
}
if (Subcommand == "--version") {
cl::PrintVersionMessage();
return 0;
}
return usage();
}
Loading