Skip to content

[clang-doc] fix ASan complaints from passing RepositoryURL as reference #148923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

[clang-doc] fix ASan complaints from passing RepositoryURL as reference #148923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions clang-tools-extra/clang-doc/JSONGenerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ static auto SerializeReferenceLambda = [](const auto &Ref, Object &Object) {

static json::Object
serializeLocation(const Location &Loc,
const std::optional<StringRef> &RepositoryUrl) {
const std::optional<StringRef> RepositoryUrl) {
Object LocationObj = Object();
LocationObj["LineNumber"] = Loc.StartLineNumber;
LocationObj["Filename"] = Loc.Filename;
Expand Down Expand Up @@ -169,7 +169,7 @@ static json::Value serializeComment(const CommentInfo &I) {

static void
serializeCommonAttributes(const Info &I, json::Object &Obj,
const std::optional<StringRef> &RepositoryUrl) {
const std::optional<StringRef> RepositoryUrl) {
Obj["Name"] = I.Name;
Obj["USR"] = toHex(toStringRef(I.USR));

Expand Down Expand Up @@ -211,9 +211,9 @@ static void serializeReference(const Reference &Ref, Object &ReferenceObj) {
// differently. Only enums, records, and typedefs are handled here.
static void
serializeCommonChildren(const ScopeChildren &Children, json::Object &Obj,
const std::optional<StringRef> &RepositoryUrl) {
static auto SerializeInfo = [&RepositoryUrl](const auto &Info,
Object &Object) {
const std::optional<StringRef> RepositoryUrl) {
static auto SerializeInfo = [RepositoryUrl](const auto &Info,
Object &Object) {
serializeInfo(Info, Object, RepositoryUrl);
};

Expand Down Expand Up @@ -304,7 +304,7 @@ static void serializeInfo(const FieldTypeInfo &I, Object &Obj) {
}

static void serializeInfo(const FunctionInfo &F, json::Object &Obj,
const std::optional<StringRef> &RepositoryURL) {
const std::optional<StringRef> RepositoryURL) {
serializeCommonAttributes(F, Obj, RepositoryURL);
Obj["IsStatic"] = F.IsStatic;

Expand Down Expand Up @@ -459,7 +459,7 @@ static void serializeInfo(const RecordInfo &I, json::Object &Obj,
}

static void serializeInfo(const VarInfo &I, json::Object &Obj,
const std::optional<StringRef> &RepositoryUrl) {
const std::optional<StringRef> RepositoryUrl) {
serializeCommonAttributes(I, Obj, RepositoryUrl);
Obj["IsStatic"] = I.IsStatic;
auto TypeObj = Object();
Expand All @@ -468,15 +468,15 @@ static void serializeInfo(const VarInfo &I, json::Object &Obj,
}

static void serializeInfo(const NamespaceInfo &I, json::Object &Obj,
const std::optional<StringRef> &RepositoryUrl) {
const std::optional<StringRef> RepositoryUrl) {
serializeCommonAttributes(I, Obj, RepositoryUrl);

if (!I.Children.Namespaces.empty())
serializeArray(I.Children.Namespaces, Obj, "Namespaces",
SerializeReferenceLambda);

static auto SerializeInfo = [&RepositoryUrl](const auto &Info,
Object &Object) {
static auto SerializeInfo = [RepositoryUrl](const auto &Info,
Object &Object) {
serializeInfo(Info, Object, RepositoryUrl);
};

Expand Down
Loading