Skip to content

[libc] Implement barriers for pthreads #148948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 28, 2025
Merged

[libc] Implement barriers for pthreads #148948

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2d5b880
Barrier class implemented; begin work on public functions
uzairnawaz Jul 10, 2025
cefd7de
pthread test + public function
uzairnawaz Jul 15, 2025
d645f95
fix test to join threads
uzairnawaz Jul 15, 2025
8cad8c0
implemented return value for barrier wait
uzairnawaz Jul 15, 2025
7adf56a
formatting
uzairnawaz Jul 15, 2025
a349e6f
mark attr param as unused
uzairnawaz Jul 15, 2025
d901a37
reorganized for readability
uzairnawaz Jul 18, 2025
0512e7f
used internal pthread header
uzairnawaz Jul 18, 2025
ecf9f6c
fix pthread_barrier_t public struct opaqueness/alignment + test cleanup
uzairnawaz Jul 22, 2025
1a828f4
formatting
uzairnawaz Jul 22, 2025
3122439
header typo
uzairnawaz Jul 22, 2025
e20d450
more header typos
uzairnawaz Jul 22, 2025
4373ef7
formatting
uzairnawaz Jul 22, 2025
7bbd476
make barrier linux-only for now as mutex/cndvars are only defined for it
uzairnawaz Jul 24, 2025
1e80063
remove unnecesary braces
uzairnawaz Jul 25, 2025
86b9074
remove extra header + force size of public barrier type to be exactly…
uzairnawaz Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libc/src/__support/threads/barrier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ namespace LIBC_NAMESPACE_DECL {

const int BARRIER_FIRST_EXITED = -1;

int Barrier::init(Barrier *b, const pthread_barrierattr_t *attr,
int Barrier::init(Barrier *b,
const pthread_barrierattr_t *attr __attribute__((unused)),
unsigned count) {
LIBC_ASSERT(attr == nullptr); // TODO implement barrierattr
if (count == 0)
Expand Down
Loading