Skip to content

[Offload] Introduce ATTACH map-type support for pointer attachment. #149036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
+471 −37
Open

[Offload] Introduce ATTACH map-type support for pointer attachment. #149036

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5d72174
[WIP][Offload] Introduce ATTACH map-type support for pointer attachment.
abhinavgaba Jul 16, 2025
b645d58
Minor format/stylistic changes.
abhinavgaba Jul 16, 2025
de8d968
Merge remote-tracking branch 'upstream/main' into libomptarget-introd…
abhinavgaba Jul 27, 2025
168a2b8
add dataFence to plugin interface
adurang Jul 25, 2025
2370215
Clang-format fixes.
abhinavgaba Jul 27, 2025
2806389
Insert a data-fence before the first pointer-attachment.
abhinavgaba Jul 27, 2025
40320d2
Use unique_ptr, avoid c-style casts.
abhinavgaba Jul 30, 2025
39e4ab1
Add newline at end of file.
abhinavgaba Aug 1, 2025
eb35a3e
Clean-up some debug prints.
abhinavgaba Aug 5, 2025
4517cd2
Do pointee lookup and release its TPR before pointer lookup.
abhinavgaba Aug 8, 2025
cb21ea4
Use a lambda to avoid uninitialized TgtPteeBegin.
abhinavgaba Aug 13, 2025
ac04da3
Merge remote-tracking branch 'upstream/main' into libomptarget-introd…
abhinavgaba Aug 13, 2025
d1ab642
Merge remote-tracking branch 'upstream/main' into libomptarget-introd…
abhinavgaba Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions offload/libomptarget/omptarget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,10 +782,10 @@ int processAttachEntries(DeviceTy &Device, AttachInfoTy &AttachInfo,
return IsNewlyAllocated;
};

// Only process ATTACH if base/begin was newly allocated OR ALWAYS flag is
// set
if (!IsAttachAlways && !WasNewlyAllocated(HstPtr, "pointer") &&
!WasNewlyAllocated(HstPteeBegin, "pointee")) {
// Only process ATTACH if either the pointee or the pointer was newly
// allocated, or the ALWAYS flag is set.
if (!IsAttachAlways && !WasNewlyAllocated(HstPteeBegin, "pointee") &&
!WasNewlyAllocated(HstPtr, "pointer")) {
DP("Skipping ATTACH entry %zu: neither pointer nor pointee was newly "
"allocated and no ALWAYS flag\n",
EntryIdx);
Expand Down Expand Up @@ -821,19 +821,22 @@ int processAttachEntries(DeviceTy &Device, AttachInfoTy &AttachInfo,
return TPR;
};

// Get device version of the pointer (e.g., &p)
// Get device version of the pointee (e.g., &p[10]) first, as we can
// release its TPR after extracting the pointer value.
void *TgtPteeBegin;
if (auto PteeTPROpt = LookupTargetPointer(HstPteeBegin, 0, "pointee"))
TgtPteeBegin = PteeTPROpt->TargetPointer;
else
continue;

// Get device version of the pointer (e.g., &p) next. We need to keep its
// TPR for use in shadow-pointer handling during pointer-attachment.
auto PtrTPROpt = LookupTargetPointer(HstPtr, PtrSize, "pointer");
if (!PtrTPROpt)
continue;
TargetPointerResultTy &PtrTPR = *PtrTPROpt;
void **TgtPtrBase = reinterpret_cast<void **>(PtrTPR.TargetPointer);

// Get device version of the pointee (e.g., &p[10])
auto PteeTPROpt = LookupTargetPointer(HstPteeBegin, 0, "pointee");
if (!PteeTPROpt)
continue;
void *TgtPteeBegin = PteeTPROpt->TargetPointer;

// Insert a data-fence before the first pointer-attachment.
if (IsFirstPointerAttachment) {
IsFirstPointerAttachment = false;
Expand Down