[libc++] Add missing include <limits> to bitset to_ullong.pass.cpp test #149149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added to to_ulong.pass.cpp years ago by cf1dc8d but I don't think the other part of that commit matters here.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Jonathan Wakely (jwakely) ChangesThis was added to to_ulong.pass.cpp years ago by Full diff: https://github.com/llvm/llvm-project/pull/149149.diff 1 Files Affected:
diff --git a/libcxx/test/std/utilities/template.bitset/bitset.members/to_ullong.pass.cpp b/libcxx/test/std/utilities/template.bitset/bitset.members/to_ullong.pass.cpp
index 5df6103d79e7a..3c5a57d1c7fec 100644
--- a/libcxx/test/std/utilities/template.bitset/bitset.members/to_ullong.pass.cpp
+++ b/libcxx/test/std/utilities/template.bitset/bitset.members/to_ullong.pass.cpp
@@ -11,6 +11,7 @@
#include <bitset>
#include <algorithm>
#include <type_traits>
+#include <limits>
#include <climits>
#include <cassert>
#include <stdexcept>
|
frederick-vs-ja
approved these changes
Jul 17, 2025
philnik777
approved these changes
Jul 17, 2025
This was referenced Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added to to_ulong.pass.cpp years ago by
cf1dc8d but I don't think the other part of that commit matters here.