-
Notifications
You must be signed in to change notification settings - Fork 14.9k
[libcxx] Update testing documentation about CI container images. #149192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
a15e371
757baec
18f213f
bf0596a
f37621e
f0651fb
0677c57
8d68e8c
c2b97d3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -174,10 +174,11 @@ Pre-commit CI | |||||
Introduction | ||||||
------------ | ||||||
|
||||||
Unlike most parts of the LLVM project, libc++ uses a pre-commit CI [#]_. This | ||||||
CI is hosted on `Buildkite <https://buildkite.com/llvm-project/libcxx-ci>`__ and | ||||||
the build results are visible in the review on GitHub. Please make sure | ||||||
the CI is green before committing a patch. | ||||||
Unlike most parts of the LLVM project, libc++ uses a pre-commit CI [#]_. Some of | ||||||
this CI is hosted on `Buildkite<https://buildkite.com/llvm-project/libcxx-ci>`__, | ||||||
but some has migrated to the LLVM CI infrastructure. The build results are | ||||||
visible in the review on GitHub. Please make sure the CI is green before | ||||||
committing a patch. | ||||||
|
||||||
The CI tests libc++ for all :ref:`supported platforms <SupportedPlatforms>`. | ||||||
The build is started for every commit added to a Pull Request. A complete CI | ||||||
|
@@ -246,12 +247,15 @@ Below is a short description of the most interesting CI builds [#]_: | |||||
Infrastructure | ||||||
-------------- | ||||||
|
||||||
All files of the CI infrastructure are in the directory ``libcxx/utils/ci``. | ||||||
Note that quite a bit of this infrastructure is heavily Linux focused. This is | ||||||
the platform used by most of libc++'s Buildkite runners and developers. | ||||||
The files for the CI infrastructure are split between the llvm-project | ||||||
and the llvm-zorg repositories. All files of the CI infrastructure in | ||||||
|
and the llvm-zorg repositories. All files of the CI infrastructure in | |
and the llvm-zorg repositories. All files of the CI infrastructure in |
One space after a period, throughout!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the llvm-project are in the directory ``libcxx/utils/ci``. Note that | |
the llvm-project are in the directory ``libcxx/utils/ci``. Note that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: or->and
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the LLVM premerge maintainer -> a LLVM premerge maintainer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done