Skip to content

[asan] Revert global check for non-AIX #149245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2025
Merged

[asan] Revert global check for non-AIX #149245

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
205441b
revert
jakeegan Jul 17, 2025
998ec16
Fix formatting
jakeegan Jul 17, 2025
505360a
Add comment
jakeegan Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions compiler-rt/lib/asan/asan_descriptions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,10 +449,12 @@ AddressDescription::AddressDescription(uptr addr, uptr access_size,
// are put to the STACK region for unknown reasons. Check global first can
// workaround this issue.
// TODO: Look into whether there's a different solution to this problem.
#if SANITIZER_AIX
if (GetGlobalAddressInformation(addr, access_size, &data.global)) {
data.kind = kAddressKindGlobal;
return;
}
#endif

if (GetHeapAddressInformation(addr, access_size, &data.heap)) {
data.kind = kAddressKindHeap;
Expand All @@ -471,6 +473,14 @@ AddressDescription::AddressDescription(uptr addr, uptr access_size,
return;
}

// GetGlobalAddressInformation is called earlier on AIX due to a workaround
#if !SANITIZER_AIX
if (GetGlobalAddressInformation(addr, access_size, &data.global)) {
data.kind = kAddressKindGlobal;
return;
}
#endif

data.kind = kAddressKindWild;
data.wild.addr = addr;
data.wild.access_size = access_size;
Expand Down
Loading