[NFC][RA] Refactor RABasic into a Separate Header #149555
Conversation
This change refactors the RABasic type by moving it from RegAllocBasic.cpp to a new header file, RegAllocBasic.h. This separation of header and implementation aligns with the structure used by other register allocators, such as RegAllocGreedy. The refactoring is intended to facilitate future use of RABasic in other contexts.
kyulee-com
requested review from
MatzeB,
ellishg,
akshaykhadse,
DataCorrupted,
cdevadas and
jurahul
llvm/lib/CodeGen/RegAllocBasic.h
Outdated
| // This file declares the RABasic class, which provides a minimal | ||
| // implementation of the basic register allocator. |
There was a problem hiding this comment.
use syntax recognized by doxygen (and possibly fix the pre-existing problem in RegAllocBasic.cpp)
| // This file declares the RABasic class, which provides a minimal | |
| // implementation of the basic register allocator. | |
| /// \file This file declares the RABasic class, which provides a minimal | |
| /// implementation of the basic register allocator. |
llvm/lib/CodeGen/RegAllocBasic.h
Outdated
| #ifndef LLVM_CODEGEN_REGALLOCBAISC_H_ | ||
| #define LLVM_CODEGEN_REGALLOCBAISC_H_ |
There was a problem hiding this comment.
| #ifndef LLVM_CODEGEN_REGALLOCBAISC_H_ | |
| #define LLVM_CODEGEN_REGALLOCBAISC_H_ | |
| #ifndef LLVM_CODEGEN_REGALLOCBASIC_H | |
| #define LLVM_CODEGEN_REGALLOCBASIC_H |
There was a problem hiding this comment.
most files tend to use LLVM_LIB_CODEGEN_XXXX_H it seems...
llvm/lib/CodeGen/RegAllocBasic.h
Outdated
| static char ID; | ||
| }; | ||
| } // namespace llvm | ||
| #endif // #ifndef LLVM_CODEGEN_REGALLOCBAISC_H_ |
There was a problem hiding this comment.
| #endif // #ifndef LLVM_CODEGEN_REGALLOCBAISC_H_ | |
| #endif |
llvm/lib/CodeGen/RegAllocBasic.h
Outdated
| #include "llvm/CodeGen/LiveIntervals.h" | ||
| #include "llvm/CodeGen/LiveRangeEdit.h" | ||
| #include "llvm/CodeGen/LiveRegMatrix.h" | ||
| #include "llvm/CodeGen/MachineFunctionPass.h" | ||
| #include "llvm/CodeGen/Spiller.h" | ||
| #include "llvm/CodeGen/VirtRegMap.h" |
There was a problem hiding this comment.
Please check which include files are actually needed, and which ones can be replaced with class xxx; forward declarations. LiveRegMatrix and VirtRegMap seem unused at a first glance...
@MatzeB Thanks for the review! Incorporated the feedbacks. I’m currently working on a prototype for a wrapper RA that dispatches different RAs based on function profiles or heuristics. Depending on how complete and generally applicable it becomes, this feature could be upstreamed in the future. |
|
Going to accept. LGTM (Though admittedly I feel we should rather understand why exactly regallocbasic performs better in the "codesize after compression" metric and aim at tweaking greedy alloc instead of adding higher level complexity...) |
This change refactors the RABasic type by moving it from RegAllocBasic.cpp to a new header file, RegAllocBasic.h. This separation of header and implementation aligns with the structure used by other register allocators, such as RegAllocGreedy. The refactoring is intended to facilitate future use of RABasic in other contexts.
This change refactors the RABasic type by moving it from RegAllocBasic.cpp to a new header file, RegAllocBasic.h. This separation of header and implementation aligns with the structure used by other register allocators, such as RegAllocGreedy. The refactoring is intended to facilitate future use of RABasic in other contexts.