Skip to content

[WebAssembly] Generate a call to __wasm_apply_global_tls_relocs in __wasm_init_memory #149832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WebAssembly] Generate a call to __wasm_apply_global_tls_relocs in __wasm_init_memory #149832

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
738d8b1
Generate a call to __wasm_apply_global_tls_relocs in __wasm_init_memory
Arshia001 Jul 21, 2025
d517621
* Update comment on `lld::wasm::Writer::createApplyGlobalTLSRelocatio…
Arshia001 Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lld/wasm/Writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1366,6 +1366,15 @@ void Writer::createInitMemoryFunction() {
writeUleb128(os, s->index, "segment index immediate");
writeU8(os, 0, "memory index immediate");
}

// After initializing the TLS segment, we also need to apply TLS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "After initializing the TLS segment and setting __tls_base we can call __wasm_apply_global_tls_relocs"

// relocations in the same way __wasm_init_tls does.
if (ctx.arg.sharedMemory && s->isTLS() &&
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ctx.arg.sharedMemory is probably redundant here since without it applyGlobalTLSRelocs would never be created.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

ctx.sym.applyGlobalTLSRelocs) {
writeU8(os, WASM_OPCODE_CALL, "CALL");
writeUleb128(os, ctx.sym.applyGlobalTLSRelocs->getFunctionIndex(),
"function index");
}
}
}

Expand Down